refactor(Bookmark): Bookmark 응답 response 변경

[Jjiggu]

작업 요약

Bookmark 응답 response 변경

Issue Link

#156

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

• 신규 기능

  • 북마크 목록 조회 시 매장 상세 정보(이미지, 대기 현황, 부서명 등)가 함께 제공됩니다.

• 버그 수정

  • 사용자 조회 시 더 구체적인 오류 메시지가 제공됩니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

BookmarkService의 getBookmarks 메서드가 북마크 엔티티에서 직접 DTO를 생성하던 기존 방식에서, StoreService를 통해 storeId 목록에 해당하는 StorePageReadDto 리스트를 반환하도록 변경되었습니다. 이를 위해 StoreService 및 StoreRepository에 관련 메서드가 추가되었습니다.

Changes

파일/경로	변경 요약
.../bookmark/service/BookmarkService.java	getBookmarks 메서드 반환 타입 및 내부 로직 변경, StoreService 의존성 주입, UserNotFoundException 적용
.../store/service/StoreService.java	storeId 리스트로 StorePageReadDto를 반환하는 getAllStoresByPageAndDeparments 메서드 시그니처 추가
.../store/service/StoreServiceImpl.java	storeId 리스트로 StorePageReadDto 리스트를 생성하는 getAllStoresByPageAndDeparments 메서드 구현
.../store/repository/StoreRepository.java	storeId 리스트로 Store 엔티티를 조회하는 findAllByStoreIdInOrderByStoreIdAsc 메서드 추가

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BookmarkService
    participant StoreService
    participant StoreRepository
    participant Redis
    participant ImageRepository
    participant DepartmentRepository

    User->>BookmarkService: getBookmarks(customOAuth2User)
    BookmarkService->>StoreService: getAllStoresByPageAndDeparments(storeIds)
    StoreService->>StoreRepository: findAllByStoreIdInOrderByStoreIdAsc(storeIds)
    StoreService->>Redis: getWaitingCount(storeId)
    StoreService->>ImageRepository: findAllByStoreIdIn(storeIds)
    StoreService->>DepartmentRepository: findAllByDepartmentIdIn(departmentIds)
    StoreService-->>BookmarkService: List<StorePageReadDto>
    BookmarkService-->>User: List<StorePageReadDto>

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15–20 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2eefa13 and a508982.

📒 Files selected for processing (4)

• nowait-app-user-api/src/main/java/com/nowait/applicationuser/bookmark/service/BookmarkService.java (3 hunks)
• nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/service/StoreService.java (1 hunks)
• nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/service/StoreServiceImpl.java (1 hunks)
• nowait-domain/domain-core-rdb/src/main/java/com/nowait/domaincorerdb/store/repository/StoreRepository.java (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refactor/#156-bookmark-response

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.