msvc analysis: suppress C26819/C28251 advisories, bump EOL actions#3117
Merged
Conversation
The PREfast (MSVC /analyze) workflow surfaced 16 alerts that are pure style/advisory, not memory-safety: 14x C26819 (es.78 unannotated switch fallthrough — ours are intentional, we don't annotate [[fallthrough]]; several are last-label-before-brace misfires like default: assert+break) and 2x C28251 (inconsistent SAL annotation on free_list's global operator new/new[], which intentionally carry no SAL). All 16 were dismissed in the Security tab; suppress both rules at the ruleset source so a future manual run stays clean instead of re-raising them. Also bump the two EOL actions in this workflow to the repo standard: upload-sarif v2 -> v3, upload-artifact v3 -> v4. (msvc-code-analysis-action stays v0.1.1 — no newer release exists.) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR keeps the MSVC /analyze (PREfast) manual workflow clean by suppressing two advisory-style diagnostics in the shared ruleset, and aligns the workflow’s action versions with the repository’s current standards.
Changes:
- Suppress PREfast advisories C26819 (unannotated switch fallthrough) and C28251 (SAL annotation inconsistency) in
CustomRules.ruleset. - Bump
github/codeql-action/upload-sariffromv2tov3in the MSVC analysis workflow. - Bump
actions/upload-artifactfromv3tov4in the MSVC analysis workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
CustomRules.ruleset |
Adds suppressions for C26819 and C28251 to prevent re-raising dismissed advisories on manual /analyze runs. |
.github/workflows/msvc.yml |
Updates SARIF upload and artifact upload actions to the repo-standard major versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the CodeQL cleanup (#3112). The PREfast / MSVC
/analyzeworkflow had left 16 alerts in the Security tab — all pure style/advisory, none memory-safety:[[fallthrough]]; several are last-label-before-brace misfires (e.g.default: DAS_ASSERT(0); break;, which isn't even a fallthrough). 5 of these are in vendored stb single-file headers.free_list's globaloperator new/new[]) — our allocators intentionally carry no SAL annotations; nothing relies on the contract.All 16 were dismissed (won't-fix) in the Security tab. This suppresses both rules at the ruleset source (
CustomRules.ruleset, alongside the existingC26451/C26495/C26439/C26813/C6255exclusions) so a future manual run stays clean rather than re-raising them as new alerts (the workflow isworkflow_dispatch-only, so this only fires on a manual trigger anyway).Also bumps the two EOL actions in this workflow to the repo standard used by the other workflows:
codeql-action/upload-sarifv2→v3,actions/upload-artifactv3→v4.microsoft/msvc-code-analysis-actionstays at v0.1.1 — no newer release exists.Can't be CI-validated pre-merge (the workflow is manual-dispatch and Windows-only), but the changes are a ruleset rule-list addition + two action version pins.
🤖 Generated with Claude Code