Skip to content

msvc analysis: suppress C26819/C28251 advisories, bump EOL actions #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
borisbat merged 1 commit into from
Jun 12, 2026
+4 −2
Merged

msvc analysis: suppress C26819/C28251 advisories, bump EOL actions #3117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/msvc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ jobs:

# Upload SARIF file to GitHub Code Scanning Alerts
- name: Upload SARIF to GitHub
uses: github/codeql-action/upload-sarif@v2
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: ${{ steps.run-analysis.outputs.sarif }}

# Upload SARIF file as an Artifact to download and view
- name: Upload SARIF as an Artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: sarif-file
path: ${{ steps.run-analysis.outputs.sarif }}
2 changes: 2 additions & 0 deletions CustomRules.ruleset
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,7 @@
<Rule Id="C26439" Action="None" /> <!-- Exclude: This kind of function should not throw. Declare it 'noexcept' (f.6). -->
<Rule Id="C26813" Action="None" /> <!-- Exclude: Use 'bitwise and' to check if a flag is set. -->
<Rule Id="C6255" Action="None" /> <!-- _alloca indicates failure by raising a stack overflow exception. Consider using _malloca instead. -->
<Rule Id="C26819" Action="None" /> <!-- Exclude: Unannotated fallthrough between switch labels (es.78). Advisory; our fallthroughs are intentional and we don't annotate with [[fallthrough]]. -->
<Rule Id="C28251" Action="None" /> <!-- Exclude: Inconsistent SAL annotation for operator new/new[]. Our global allocators (free_list) intentionally carry no SAL annotations. -->
</Rules>
</RuleSet>
Loading