migrate to slnx and upgrade github actions#180
migrate to slnx and upgrade github actions#180WeihanLi wants to merge 2 commits intoGeneralLibrary:masterfrom
Conversation
WeihanLi
commented
Apr 28, 2026
WeihanLi
commented
- migrate to slnx
- upgrade github actions
There was a problem hiding this comment.
Pull request overview
Migrates the C# solution from the legacy .sln format to the new .slnx format and updates the GitHub Actions workflow to use the new solution file while bumping action versions.
Changes:
- Add
src/c#/GeneralUpdate.slnxand removesrc/c#/GeneralUpdate.sln. - Update CI to restore/build using the
.slnxsolution file. - Bump GitHub Actions used in the publishing workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/c#/GeneralUpdate.slnx |
Introduces the new .slnx solution definition for src + tests. |
src/c#/GeneralUpdate.sln |
Removes the old Visual Studio .sln solution file. |
.github/workflows/dotnet-ci.yaml |
Updates solution path to .slnx and upgrades referenced GitHub Actions versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Project Path="BowlTest/BowlTest.csproj" /> | ||
| <Project Path="ClientCoreTest/ClientCoreTest.csproj" /> | ||
| <Project Path="CoreTest/CoreTest.csproj" /> | ||
| <Project Path="DifferentialTest/DifferentialTest.csproj" /> |
There was a problem hiding this comment.
The solution includes several test projects under /tests/, but DrivelutionTest/DrivelutionTest.csproj (present in src/c#/DrivelutionTest/) is not listed. This means dotnet build/IDE solution load will skip that test project, reducing compile/test coverage. Consider adding it to the /tests/ folder in the .slnx.
| <Project Path="DifferentialTest/DifferentialTest.csproj" /> | |
| <Project Path="DifferentialTest/DifferentialTest.csproj" /> | |
| <Project Path="DrivelutionTest/DrivelutionTest.csproj" /> |
There was a problem hiding this comment.
This is migrated from the original solution file via dotnet sln migrate, so I think the DrivelutionTest/DrivelutionTest.csproj project should not be added to follow original solution
There was a problem hiding this comment.
This is migrated from the original solution file via
dotnet sln migrate, so I think theDrivelutionTest/DrivelutionTest.csprojproject should not be added to follow original solution
It is necessary to create a separate .slnx file for test?
There was a problem hiding this comment.
DrivelutionTest/DrivelutionTest.csproj is not included in the original solution file, so the updated slnx also did not include the project either.
We could include it in the slnx if needed, did not not include it so far to keep it same as before.
There was a problem hiding this comment.
DrivelutionTest/DrivelutionTest.csprojis not included in the original solution file, so the updated slnx also did not include the project either.DrivelutionTest/DrivelutionTest.csproj未包含在原始解答文件中，因此更新后的 SLNX 也未包含该项目。 We could include it in the slnx if needed, did not not include it so far to keep it same as before.如果需要，我们可以把它写进 SLNX，但之前没写，就是为了保持之前的效果。
sure
