Skip to content

migrate to slnx and upgrade github actions #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WeihanLi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

migrate to slnx and upgrade github actions #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
651af4e
chore: migrate to slnx and upgrade github actions
WeihanLi Apr 28, 2026
d661550
remove unnecessary configuration
WeihanLi Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/dotnet-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,18 @@ jobs:
runs-on: windows-latest
steps:
- name: 检出代码
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: 安装.NET SDK
uses: actions/setup-dotnet@v4
uses: actions/setup-dotnet@v5
with:
dotnet-version: '10.0.x' # 支持GeneralUpdate.Drivelution的.NET 10目标框架

- name: 恢复依赖
run: dotnet restore ./src/c#/GeneralUpdate.sln # 使用解决方案统一恢复
run: dotnet restore ./src/c#/GeneralUpdate.slnx # 使用解决方案统一恢复

- name: 构建项目（确保生成DLL）
run: dotnet build ./src/c#/GeneralUpdate.sln -c Release --no-restore # 显式构建，避免重复恢复
run: dotnet build ./src/c#/GeneralUpdate.slnx -c Release --no-restore # 显式构建，避免重复恢复

- name: 打包NuGet包
run: |
Expand All @@ -49,7 +49,7 @@ jobs:
shell: pwsh

- name: 创建GitHub Release并上传NuGet包
uses: softprops/action-gh-release@v2
uses: softprops/action-gh-release@v3
with:
tag_name: v${{ github.event.inputs.version }}
name: Release v${{ github.event.inputs.version }}
Expand Down
209 changes: 0 additions & 209 deletions src/c#/GeneralUpdate.sln
View file
Open in desktop

This file was deleted.

18 changes: 18 additions & 0 deletions src/c#/GeneralUpdate.slnx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<Solution>
<Folder Name="/src/">
<Project Path="GeneralUpdate.Bowl/GeneralUpdate.Bowl.csproj" />
<Project Path="GeneralUpdate.ClientCore/GeneralUpdate.ClientCore.csproj" />
<Project Path="GeneralUpdate.Common/GeneralUpdate.Common.csproj" />
<Project Path="GeneralUpdate.Core/GeneralUpdate.Core.csproj" />
<Project Path="GeneralUpdate.Differential/GeneralUpdate.Differential.csproj" />
<Project Path="GeneralUpdate.Drivelution/GeneralUpdate.Drivelution.csproj" />
<Project Path="GeneralUpdate.Extension/GeneralUpdate.Extension.csproj" />
</Folder>
<Folder Name="/tests/">
<Project Path="BowlTest/BowlTest.csproj" />
<Project Path="ClientCoreTest/ClientCoreTest.csproj" />
<Project Path="CoreTest/CoreTest.csproj" />
<Project Path="DifferentialTest/DifferentialTest.csproj" />
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution includes several test projects under /tests/, but DrivelutionTest/DrivelutionTest.csproj (present in src/c#/DrivelutionTest/) is not listed. This means dotnet build/IDE solution load will skip that test project, reducing compile/test coverage. Consider adding it to the /tests/ folder in the .slnx.

Suggested change
<Project Path="DifferentialTest/DifferentialTest.csproj" />
<Project Path="DifferentialTest/DifferentialTest.csproj" />
<Project Path="DrivelutionTest/DrivelutionTest.csproj" />

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@WeihanLi WeihanLi Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is migrated from the original solution file via dotnet sln migrate, so I think the DrivelutionTest/DrivelutionTest.csproj project should not be added to follow original solution

Copy link
Copy Markdown
Collaborator

@JusterZhu JusterZhu Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is migrated from the original solution file via dotnet sln migrate, so I think the DrivelutionTest/DrivelutionTest.csproj project should not be added to follow original solution

It is necessary to create a separate .slnx file for test?

Copy link
Copy Markdown
Contributor Author

@WeihanLi WeihanLi May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DrivelutionTest/DrivelutionTest.csproj is not included in the original solution file, so the updated slnx also did not include the project either.
We could include it in the slnx if needed, did not not include it so far to keep it same as before.

Copy link
Copy Markdown
Collaborator

@JusterZhu JusterZhu May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DrivelutionTest/DrivelutionTest.csproj is not included in the original solution file, so the updated slnx also did not include the project either.DrivelutionTest/DrivelutionTest.csproj 未包含在原始解答文件中，因此更新后的 SLNX 也未包含该项目。 We could include it in the slnx if needed, did not not include it so far to keep it same as before.如果需要，我们可以把它写进 SLNX，但之前没写，就是为了保持之前的效果。

sure

<Project Path="ExtensionTest/ExtensionTest.csproj" />
</Folder>
</Solution>
Loading