[Fixes #13968] Fix of the JS SyntaxError in the Import Resources UI

[Gpetrak]

This PR was created according to this issue: #13968

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
• New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[gemini-code-assist]

Summary of Changes

Hello @Gpetrak, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a JavaScript syntax error that occurred in the Import Resources UI. The fix involves properly escaping string values for resource titles and abstracts when they are embedded into JavaScript code within the template, thereby preventing malformed script and ensuring the UI functions as expected.

Highlights

• JavaScript Syntax Error Fix: Resolved a JavaScript SyntaxError in the Import Resources UI by applying the escapejs filter to resource title and abstract fields within the template. This ensures that special characters in these fields are correctly escaped when rendered into JavaScript, preventing malformed script.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• geonode/services/templates/services/service_resources_harvest.html
  • Applied escapejs filter to resource_meta.title to prevent JavaScript syntax errors.
  • Applied escapejs filter to resource_meta.abstract to prevent JavaScript syntax errors.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a JavaScript syntax error by using the escapejs filter for dynamic content injected into a JavaScript block. The fix is appropriate and necessary. I've provided one suggestion to refine the filter chain for the abstract field to ensure truncation is applied to the plain text content after HTML tags are removed, which will produce more predictable and correct output.

[gemini-code-assist]

The order of the truncatechars and striptags filters should be swapped. It is more robust to strip HTML tags before truncating the string. This ensures that truncation applies to the actual content text rather than the HTML markup, preventing broken HTML and providing a more accurate truncation of the visible text.

                abstract: '{{ resource_meta.abstract|striptags|truncatechars:20|escapejs }}',

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.22%. Comparing base (a3959be) to head (1a4eb0b).
⚠️ Report is 24 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #13969      +/-   ##
==========================================
- Coverage   74.24%   74.22%   -0.03%     
==========================================
  Files         947      948       +1     
  Lines       56620    56591      -29     
  Branches     7675     7668       -7     
==========================================
- Hits        42038    42005      -33     
- Misses      12892    12898       +6     
+ Partials     1690     1688       -2     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.