Skip to content

[Fixes #13968] Fix of the JS SyntaxError in the Import Resources UI #13969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gpetrak wants to merge 1 commit into from
+2 −2
Closed

[Fixes #13968] Fix of the JS SyntaxError in the Import Resources UI #13969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions geonode/services/templates/services/service_resources_harvest.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,8 @@ <h3><strong>{{service.title|default:service.name}}</strong></h3>
resources.push({
id: '{{ resource_meta.id }}',
name: '{{ resource_meta.unique_identifier }}',
title: '{{ resource_meta.title }}',
abstract: '{{ resource_meta.abstract|safe|truncatechars:20|striptags }}',
title: '{{ resource_meta.title|escapejs }}',
abstract: '{{ resource_meta.abstract|truncatechars:20|striptags|escapejs }}',
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The order of the truncatechars and striptags filters should be swapped. It is more robust to strip HTML tags before truncating the string. This ensures that truncation applies to the actual content text rather than the HTML markup, preventing broken HTML and providing a more accurate truncation of the visible text.

                abstract: '{{ resource_meta.abstract|striptags|truncatechars:20|escapejs }}',

type: '{{ resource_meta.remote_resource_type }}'
});
{% endfor %}
Expand Down
Loading