fix(ui): modify closed captions and recording options to use partial call state builder#1180
fix(ui): modify closed captions and recording options to use partial call state builder#1180mboyamike wants to merge 3 commits intoGetStream:mainfrom
Conversation
This makes the call recording option button be more consistent with the other buttons. It also has the benefit of making it reactive to changes in state of recording
This makes the closed captions option button consisted with the other control options, as well as making it more reactive to the call state
📝 WalkthroughWalkthroughTwo call control widgets refactored to use PartialCallStateBuilder pattern, replacing direct synchronous state access with reactive state subscription through selectors. Functionality and public APIs remain unchanged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Semantic changelog update is failing, but I'm not sure if that's something I should change as an outside contributor |
|
Hi @mboyamike, thanks for taking the time to contribute this! The change you propose makes sense. If you’re okay spending a bit more time on it, please run If you’d prefer not to spend any more time on this, just let us know. We can open a separate PR that builds on your changes. Thanks again! |
|
Thanks for checking it out @Brazol Yeah I can do so. Should the changelog entry be in version 1.3.0 or should I start a 1.3.1? |
|
Cause of the latency in communication, I think it'll be faster if you just did it from your side |
🎯 Goal
Options like the ToggleCameraOption use the partial call state builder. This helps them be reactive to the state of the call.
The recording option and closed captions option check the state at build. This has the potential to show stale information after some time. The goal of this change is to have both use the partial call state builder to be consistent with the other options and ensure they are reactive
🛠 Implementation details
Uses the callstatebuilder to check for recording and closed captions
🎨 UI Changes
No UI change.
🧪 Testing
Generally use the streamcallcontainer on a call, and have its call controls include a recording/closed captions option.
Change any of those states from a different device and see them also react to the change
☑️Contributor Checklist
General
☑️Reviewer Checklist
Summary by CodeRabbit