fix: UX and dev mode improvements by gmenher · Pull Request #18 · Gkrumbach07/openshell-dashboard

gmenher · 2026-08-05T17:31:48Z

Summary

Fixes the About modal text wrapping issue found during initial review.

About modal text wrapping

Labels like "Dashboard version" were wrapping mid-word at narrow widths.

Fix: Changed DescriptionList to use isAutoFit with autoFitMinModifier so items reflow responsively.

Note: This PR originally addressed three issues (terminal CORS, gRPC error extraction, and About modal). The scope has been reduced because:

Terminal CORS — resolved by PR refactor: relay-only BFF — remove the in-app identity layer (ADR 0014) #29 which removed CORS/ALLOWED_ORIGINS from the BFF entirely (relay-only architecture).
gRPC error extraction — merged via PR fix(security): harden BFF auth endpoints and federated CSS #25 (errors.As + GRPCStatus() interface).

Only the About modal fix remains.

Testing

Manual: About modal renders labels without mid-word wrapping at narrow viewports.

Address review feedback on Gkrumbach07#18: 1. ALLOWED_ORIGINS: Keep default empty (preserves same-origin fallback in production). Auto-add http://localhost:3000 only when AUTH_DISABLED=true, so make dev works out of the box without breaking deployments that rely on the same-origin WebSocket check. 2. gRPC error extraction: Replace fragile sanitizeGrpcMessage (regex + colon-splitting heuristic) with errors.As + GRPCStatus() interface. This extracts the original clean gateway message directly, bypassing status.FromError's behavior of replacing the message with the full fmt.Errorf wrapper chain (grpc-go v1.82+). No stripping heuristic needed — the source is clean from the start. 3. Add test coverage: TestWriteGrpcErrorWrapped covers the real scenario (gateway layer wraps gRPC errors with fmt.Errorf). Verifies that short messages ('not found', 'denied') and long messages are all extracted cleanly regardless of wrapper context. 4. About modal: Use isAutoFit with autoFitMinModifier for responsive layout without mid-word wrapping.

Gkrumbach07 · 2026-08-08T04:05:50Z

Hey @gmenher — this needs a rebase onto current main. PR #29 removed CORS/ALLOWED_ORIGINS entirely, so the main.go change is no longer needed. The other two fixes (gRPC error extraction via errors.As + About modal isAutoFit) still apply cleanly and are good to go.

To rebase:

Drop the main.go hunk (CORS auto-add is obsolete)
Rebase respond.go, respond_ext_test.go, and AppLayout.tsx onto main
The gRPC fix and About modal fix apply without conflicts

Use isAutoFit with autoFitMinModifier on the DescriptionList so items reflow responsively instead of breaking labels mid-word at narrow widths.