Remove unused includes to speed up compilation (IWYU cleanup)#372
Draft
Remove unused includes to speed up compilation (IWYU cleanup)#372
Conversation
Co-authored-by: tsaubergine <732276+tsaubergine@users.noreply.github.com> Agent-Logs-Url: https://github.com/GobySoft/goby3/sessions/27fee580-1a61-45ce-bcb7-c07a57ca8bc4
Copilot stopped work on behalf of
tsaubergine due to an error
March 26, 2026 09:50
Copilot stopped work on behalf of
tsaubergine due to an error
March 26, 2026 09:52
Copilot
AI
changed the title
[WIP] Improve compilation speed by optimizing header usage
Remove unused includes to speed up compilation (IWYU cleanup)
Mar 26, 2026
tsaubergine
requested changes
Mar 26, 2026
Member
tsaubergine
left a comment
tsaubergine
left a comment
There was a problem hiding this comment.
Fix the build error that happens now:
Agent-Logs-Url: https://github.com/GobySoft/goby3/sessions/3b1842a5-f278-481b-ac41-9055611ff423 Co-authored-by: tsaubergine <732276+tsaubergine@users.noreply.github.com>
Contributor
Author
Fixed in 039cdea. The build error was caused by removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<iosfwd>and<tuple>fromsrc/zeromq/transport/interprocess.h<algorithm>and<chrono>fromsrc/middleware/transport/intervehicle/driver_thread.h<boost/smart_ptr/shared_ptr.hpp>from driver_base.h, mac_manager.h, frontseat/interface.h, goby_moos_app.h<iostream>with<iosfwd>insrc/acomms/queue/queue.h<boost/smart_ptr/shared_ptr.hpp>fromsrc/acomms/dccl/dccl.cpp<iostream>to all test/source files that used it transitively via binary.h (mavlink.cpp, hdf5/test-plugin.cpp, queue1-6, udpdriver2-3, route1, ipcodecs, ip_gateway.cpp)✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.