Remove unused includes to speed up compilation (IWYU cleanup)

src/apps/zeromq/acomms/ip_gateway/ip_gateway.cpp

@@ -42,6 +42,7 @@
 #include "goby/acomms/ip_codecs.h"
 #include "goby/acomms/protobuf/modem_message.pb.h"
 #include "goby/middleware/acomms/groups.h"
+#include <iostream>
 #include "goby/util/binary.h"
 #include "goby/util/dccl_compat.h"
 #include "goby/zeromq/application/single_thread.h"

src/middleware/transport/identifier.cpp

@@ -1,3 +1,7 @@
+#include <algorithm>
+#include <string>
+#include <vector>
+
 #include "identifier.h"
 
 const char goby::middleware::InterProcessIdentifierManager::delimiter{'/'};

src/middleware/transport/identifier.h

@@ -2,12 +2,10 @@
 #ifndef GOBY_MIDDLEWARE_TRANSPORT_IDENTIFIER_H
 #define GOBY_MIDDLEWARE_TRANSPORT_IDENTIFIER_H
 
-#include <algorithm>
 #include <string>
 #include <thread>
 #include <unistd.h> // for getpid
 #include <unordered_map>
-#include <vector>
 
 #include "goby/middleware/group.h"
 #include "goby/middleware/marshalling/interface.h"            // for Seri...

src/middleware/transport/interprocess.h

@@ -27,7 +27,6 @@
 
 #include <atomic>
 #include <functional>
-#include <sys/types.h>
 #include <thread>
 #include <tuple>
 #include <unistd.h>

src/middleware/transport/serialization_handlers.h

@@ -25,14 +25,14 @@
 #ifndef GOBY_MIDDLEWARE_TRANSPORT_SERIALIZATION_HANDLERS_H
 #define GOBY_MIDDLEWARE_TRANSPORT_SERIALIZATION_HANDLERS_H
 
-#include <chrono>
+#include <functional>
 #include <memory>
 #include <regex>
+#include <set>
 #include <thread>
-#include <unordered_map>
+#include <vector>
 
 #include "goby/exception.h"
-#include "goby/util/binary.h"
 
 #include "goby/middleware/common.h"
 #include "goby/middleware/protobuf/intermodule.pb.h"

src/test/acomms/ipcodecs/test.cpp

@@ -26,6 +26,7 @@
 #include <netinet/in.h>
 
 #include "goby/acomms/ip_codecs.h"
+#include <iostream>
 #include "goby/util/binary.h"
 #include "goby/util/dccl_compat.h"
 #include "goby/util/debug_logger.h"

src/test/acomms/queue1/test.cpp

@@ -27,6 +27,7 @@
 #include "goby/acomms/connect.h"
 #include "goby/acomms/protobuf/modem_message.pb.h"
 #include "goby/acomms/queue.h"
+#include <iostream>
 #include "goby/util/binary.h"
 #include "goby/util/debug_logger.h"
 #include "goby/util/protobuf/io.h"

src/test/acomms/queue2/test.cpp

@@ -27,6 +27,7 @@
 #include "goby/acomms/dccl.h"
 #include "goby/acomms/protobuf/modem_message.pb.h"
 #include "goby/acomms/queue.h"
+#include <iostream>
 #include "goby/util/binary.h"
 #include "goby/util/debug_logger.h"
 #include "goby/util/protobuf/io.h"

src/test/acomms/queue3/test.cpp

@@ -28,6 +28,7 @@
 #include "goby/acomms/dccl.h"
 #include "goby/acomms/protobuf/modem_message.pb.h"
 #include "goby/acomms/queue.h"
+#include <iostream>
 #include "goby/util/binary.h"
 #include "goby/util/debug_logger.h"
 #include "goby/util/protobuf/io.h"

src/test/acomms/queue4/test.cpp

@@ -27,6 +27,7 @@
 #include "goby/acomms/dccl.h"
 #include "goby/acomms/protobuf/modem_message.pb.h"
 #include "goby/acomms/queue.h"
+#include <iostream>
 #include "goby/util/binary.h"
 #include "goby/util/debug_logger.h"
 #include "goby/util/protobuf/io.h"

src/test/acomms/queue5/test.cpp

@@ -27,6 +27,7 @@
 #include "goby/acomms/connect.h"
 #include "goby/acomms/protobuf/modem_message.pb.h"
 #include "goby/acomms/queue.h"
+#include <iostream>
 #include "goby/util/binary.h"
 #include "goby/util/debug_logger.h"
 #include "goby/util/protobuf/io.h"

src/test/acomms/queue6/test.cpp

@@ -26,6 +26,7 @@
 #include "goby/acomms/connect.h"
 #include "goby/acomms/protobuf/modem_message.pb.h"
 #include "goby/acomms/queue.h"
+#include <iostream>
 #include "goby/util/binary.h"
 #include "goby/util/debug_logger.h"
 #include "goby/util/protobuf/io.h"

src/test/acomms/route1/test.cpp

@@ -43,6 +43,7 @@
 #include "goby/test/acomms/route1/test.pb.h"
 #include "goby/time.h"
 #include "goby/util/as.h"
+#include <iostream>
 #include "goby/util/binary.h"
 #include "goby/util/debug_logger.h"
 #include <cstdlib>

src/test/acomms/udpdriver2/test.cpp

@@ -29,6 +29,7 @@
 #include "goby/acomms/protobuf/modem_message.pb.h"
 #include "goby/acomms/protobuf/udp_driver.pb.h"
 #include "goby/util/as.h"
+#include <iostream>
 #include "goby/util/binary.h"
 #include "goby/util/debug_logger.h"
 #include "goby/util/protobuf/io.h"

src/test/acomms/udpdriver3/test.cpp

@@ -30,6 +30,7 @@
 #include "goby/acomms/modemdriver/udp_driver.h"
 #include "goby/acomms/protobuf/udp_driver.pb.h"
 #include "goby/acomms/queue.h"
+#include <iostream>
 #include "goby/util/binary.h"
 #include "goby/util/debug_logger.h"
 #include "goby/util/protobuf/io.h"

src/test/middleware/hdf5/test-plugin.cpp

@@ -25,6 +25,7 @@
 #include "goby/middleware/log/hdf5/hdf5_plugin.h"
 
 #include "goby/time.h"
+#include <iostream>
 #include "goby/util/binary.h"
 
 #include "goby/test/acomms/dccl1/test.pb.h"

src/test/middleware/mavlink/mavlink.cpp

@@ -25,6 +25,7 @@
 #include <boost/test/included/unit_test.hpp>
 
 #include "goby/middleware/marshalling/mavlink.h"
+#include <iostream>
 #include "goby/util/binary.h"
 
 using goby::middleware::SerializerParserHelper;

src/test/util/nmea/nmea.cpp

@@ -25,6 +25,9 @@
 #define BOOST_TEST_MODULE nmea_test
 #include <boost/test/included/unit_test.hpp>
 
+#include <cmath>
+#include <iostream>
+
 #include "goby/util/binary.h"
 #include "goby/util/linebasedcomms.h"
 

src/util/binary.h

@@ -25,13 +25,9 @@
 #ifndef GOBY_UTIL_BINARY_H
 #define GOBY_UTIL_BINARY_H
 
-#include <cmath>
 #include <iomanip>
-#include <iostream>
 #include <sstream>
-
-#include <bitset>
-#include <boost/dynamic_bitset.hpp>
+#include <string>
 
 namespace goby
 {