Default values on properties

[rambleraptor]

Default values on properties + support for them in Ansible

---

[all]

Default values on properties

[terraform]

[puppet]

[puppet-dns]

[puppet-sql]

[puppet-compute]

[chef]

[rosbo]

Can you put the base for this PR to #145? This way, I will only see the diff related to this change.

Let me know if you need help with that.

[rosbo]

Can you rename it to default_value to be more specific?

We have a similar concept in Terraform where the default value can be either a value defined here or at runtime by the API using another boolean field default_from_api. Once you change is in, I will update terraform to use your default_value and keep the default_from_api specific to Terraform.

[nat-henderson]

I think this could be type-checked without too much difficulty, and that might be a good idea. What do you think?

[rosbo]

You can steal my validation method I wrote for Terraform: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/provider/terraform/property_override.rb#L74

Again, once you check-in this code, I will update the Terraform code to use the api.yaml defined default.

[rambleraptor]

Good call on the validation. All three nodes addressed.

[modular-magician]

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.

(terraform removed because of unrelated change)

[rosbo]

replace #{api_property.class} by #{self.class}

[rambleraptor]

Good catch!

(I also had a Rubocop fix)

[nelsonjr]

nit: it is common to have a unit associated with the value. like for example a timeout you could do: timeout_ms=long, or instead timeout=TimeUnit (where the type holds both the number and unit)

[nelsonjr]

Use case...when...else instead

[modular-magician]

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.