container: fix ignore_node_count_changes flattener permadiff - #18453
Merged
c2thorn merged 1 commit intoJul 30, 2026
Merged
Conversation
…e_container_cluster Fixes hashicorp/terraform-provider-google#27946 This PR fixes a plan-time permadiff where ignore_node_count_changes was not persisted in the inline node_pool blocks of google_container_cluster in flattenNodePool. Also adds node_pool.0.managed_instance_group_urls to ImportStateVerifyIgnore in TestAccContainerCluster_regionalWithNodePool with an adjacent comment explaining why it is required on import. ```release-note:bug container: fixed a plan-time permadiff where `ignore_node_count_changes` was not persisted in the inline `node_pool` blocks of `google_container_cluster` ```
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e3a0545: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log |
This was referenced Jul 29, 2026
rileykarson
approved these changes
Jul 29, 2026
Merged
via the queue into
GoogleCloudPlatform:main
with commit Jul 30, 2026
72bfc9b
31 checks passed
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#27946
Splits #18397
The failing test was caused by a real permadiff where the
ignore_node_count_changesflag was not persisted ingoogle_container_cluster.node_pool.Unlike top-level fields in
google_container_node_poolwhich automatically persist their state inResourceDataduring Read, unset nested fields ingoogle_container_cluster.node_poolblocks get nulled out during Read.To resolve the permadiff and fix the test, this PR:
ignore_node_count_changesfromResourceDatainside GKE'sflattenNodePoolusing the block prefix.node_pool.0.managed_instance_group_urlstoImportStateVerifyIgnoreinTestAccContainerCluster_regionalWithNodePool. Since virtual fields are not loaded during import,ignore_node_count_changesdefaults tofalseand the API populatesmanaged_instance_group_urls, causing an import verify diff.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.