chore: update GitHub Actions Runner to 2.332.0#1116
Conversation
Bump ARG RUNNER_VERSION from 2.331.0 to 2.332.0 in all three Dockerfiles (standard, chrome, chrome-go) and update the version reference in docs/VERSION_OVERVIEW.md. Closes #1114
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the GitHub Actions Runner to its latest stable version, 2.332.0, across all relevant Docker images and documentation. This ensures that the continuous integration and deployment pipelines utilize the most current runner, benefiting from the latest features, performance improvements, and security patches. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the GitHub Actions Runner version to 2.332.0 in the specified Dockerfiles and documentation. The changes themselves are accurate.
However, the update appears to be incomplete. The default RUNNER_VERSION is still hardcoded to the old version (2.331.0) in the build scripts. This could lead to inconsistencies or accidental builds using the outdated runner version if the scripts are run without explicitly overriding the version.
To ensure consistency across the project, please update the default RUNNER_VERSION in the following files:
scripts/build.shscripts/build-chrome.sh
Addressing this will make the update complete and the build process more reliable.
| # --- ARGUMENTS FOR RUNTIME --- | ||
| ARG TARGETARCH | ||
| ARG RUNNER_VERSION="2.331.0" | ||
| ARG RUNNER_VERSION="2.332.0" |
There was a problem hiding this comment.
This RUNNER_VERSION argument is defined here and also in the builder stage on line 12. Several other arguments are also duplicated between stages. To improve maintainability and avoid having to update versions in multiple places, consider declaring these arguments with their default values once at the top of the Dockerfile (before the first FROM statement). Then, within each build stage, you can simply use ARG <name> to inherit the globally defined value.
1 participant
Summary
Bumps GitHub Actions Runner from 2.331.0 → 2.332.0 across all runner variants.
Changes
docker/Dockerfile— ARG RUNNER_VERSION updated (both builder and runtime stages)docker/Dockerfile.chrome— ARG RUNNER_VERSION updateddocker/Dockerfile.chrome-go— ARG RUNNER_VERSION updateddocs/VERSION_OVERVIEW.md— Version and download URL updatedType of Change
Closes #1114