Uart rx#4
Conversation
- Replace deprecated statements - Add switch for arty-a7-100t FPGA
|
Since commiting the PR I have 2 more items that may be interesting enough to add:
Both these items require the RX functionality from this PR. Can I add these items to this PR or should I open a separate PR for these items (or wait until this PR has been considered)? Some more details on these 2 items:
|
|
Hi @patrickerich thanks for this. My apologies for letting it sit here for several months but the good news is I'm wanting to merge it. I've recently renamed super system to 'Ibex Demo System' and it's become a repository under the lowRISC organization. The PR adding your work to Ibex Demo System is here: lowRISC/ibex-demo-system#4. I've made some changes in a separate commit that's part of that PR. Ordinarily I'd review and we'd iterate towards a final version but given the length of time I've left it I felt it was better for me to just make the changes I wanted. |
|
Hi @GregAC thanks for letting me know. I will update to the 'Ibex Demo System' soon. I may have some other interesting stuff to contribute as well. |
Please consider merging in these changes.
There are 2 commits:
Possible point of attention:
In the software there is a 'circular include'. super_system includes uart and uart includes super_system.
This is not an issue because of the ifndef guards., but I am unsure if this is acceptable.
Tested set of commands to verify the functionality of this commit:
NOTES: