Uart#4
Closed
GregAC wants to merge 4 commits into
Closed
Conversation
- Replace deprecated statements - Add switch for arty-a7-100t FPGA
Refactors RTL and SW
marnovandermaas
approved these changes
Dec 7, 2022
Contributor
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
LGTM, although I have not tested it.
| void uart_out(uart_t uart, char c); | ||
|
|
||
| #endif // UART_H__ | ||
| #endif // UART_H__ No newline at end of file |
Contributor
There was a problem hiding this comment.
Nit: line return at end of file removed.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the PR which adds UART receive that's be sitting there for several months (GregAC/ibex_super_system#4) along with some changes I wanted to make