Refactor BotW logic#5649
Merged
Malkierian merged 18 commits intoHarbourMasters:developfrom Nov 12, 2025
Merged
Conversation
Co-authored-by: Demur Rumed <junkmute@hotmail.com>
serprex
reviewed
Jul 3, 2025
Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
serprex
reviewed
Jul 3, 2025
Open
serprex
approved these changes
Jul 13, 2025
serprex
reviewed
Jul 13, 2025
…m_of_the_well.cpp Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
Pepe20129
suggested changes
Nov 1, 2025
…m_of_the_well.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com>
…m_of_the_well.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com>
…m_of_the_well.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com>
serprex
reviewed
Nov 2, 2025
| Entrance(RR_BOTTOM_OF_THE_WELL_PERIMETER, []{return ctx->GetDungeon(Rando::BOTTOM_OF_THE_WELL)->IsVanilla() && logic->IsChild && logic->CanPassEnemy(RE_BIG_SKULLTULA);}), | ||
| Entrance(RR_BOTTOM_OF_THE_WELL_MQ_PERIMETER, []{return ctx->GetDungeon(Rando::BOTTOM_OF_THE_WELL)->IsMQ() && logic->IsChild;}), | ||
| Entrance(RR_KAK_WELL, []{return true;}), | ||
| //Backshot should be implemented here, or new regions should be added |
Member
There was a problem hiding this comment.
note backshot only works with hookshot, not longshot, so UI would have to allow toggling between hookshot/longshot
Pepe20129
approved these changes
Nov 2, 2025
Malkierian
approved these changes
Nov 12, 2025
Pepper0ni
added a commit
to Pepper0ni/Shipwright
that referenced
this pull request
Nov 12, 2025
* Update well logic for doorsanity Co-authored-by: Demur Rumed <junkmute@hotmail.com> * clang * Apply suggestions from code review Co-authored-by: Philip Dubé <serprex@users.noreply.github.com> * Add adult + irons + hook to getting to west ledge * Update soh/soh/Enhancements/randomizer/location_access/dungeons/bottom_of_the_well.cpp Co-authored-by: Philip Dubé <serprex@users.noreply.github.com> * post merge fixes * post merge fixes * renames and ground jumps * MQ updates * address reviews * Update soh/soh/Enhancements/randomizer/location_access/dungeons/bottom_of_the_well.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/location_access/dungeons/bottom_of_the_well.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/location_access/dungeons/bottom_of_the_well.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com> --------- Co-authored-by: Demur Rumed <junkmute@hotmail.com> Co-authored-by: Philip Dubé <serprex@users.noreply.github.com> Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #5318 and built upon due to numerous doorsanity issues being spotted, and so i can mark crawl and climb logic in comments.
I have abbreviated the names of regions in this update but not locations, to minimize the chance of conflicts with non-logic PRs while still making at least the entrance logic fit on screen.
Build Artifacts