Skip to content

Conversation

@jmandel
Copy link
Contributor

@jmandel jmandel commented Feb 8, 2026

Summary

  • Six places in expand.js, related.js, and validate.js referenced cs.contentMode (the function object) instead of cs.contentMode() (calling it)
  • This caused error messages to contain the stringified function body (e.g., "is a contentMode() { return this.codeSystem.content; }") instead of the actual content mode value
  • Also caused addParamUri to receive a function instead of a string, and content mode comparisons to silently fail since function !== 'complete' is always true

Test plan

  • Expand a ValueSet referencing a fragment CodeSystem (e.g., http://hl7.org/fhir/sid/icd-9-cm) — error message should say "is a fragment" not "is a contentMode() {...}"
  • Expand with incomplete-ok=true for a fragment CodeSystem — addParamUri should receive the string value, not a function
  • $validate-code against a fragment/example CodeSystem — contentMode.value should be a string like "fragment", not a function reference

🤖 Generated with Claude Code

jmandel and others added 2 commits February 7, 2026 23:15
…elated

Six places referenced `cs.contentMode` (the function object) instead of
`cs.contentMode()` (calling it). This caused:

- Error messages containing the stringified function body instead of the
  content mode value (e.g., "is a contentMode() { return ... }")
- `addParamUri` receiving a function instead of a string
- Content mode comparisons silently failing (function !== 'complete')

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@grahamegrieve grahamegrieve merged commit 1f1b462 into HealthIntersections:main Feb 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants