Skip to content

Fix contentMode() not being called as a function #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grahamegrieve merged 2 commits into from
Feb 8, 2026
Merged

Fix contentMode() not being called as a function #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ecf459
Fix contentMode() not being called as a function in expand/validate/r…
jmandel Feb 8, 2026
9423566
Merge branch 'main' into fix/contentMode-missing-parens
grahamegrieve Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tx/workers/expand.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ class ValueSetExpander {
} else if (cs.contentMode() === 'supplement') {
throw new Issue('error', 'business-rule', null, null, 'The code system definition for ' + cset.system + ' defines a supplement, so this expansion cannot be performed', 'invalid');
} else if (this.params.incompleteOK) {
this.addParamUri(cs.contentMode, cs.system + '|' + cs.version);
this.addParamUri(cs.contentMode(), cs.system + '|' + cs.version);
} else {
throw new Issue('error', 'business-rule', null, null, 'The code system definition for ' + cset.system + ' is a ' + cs.contentMode() + ', so this expansion is not permitted unless the expansion parameter "incomplete-ok" has a value of "true"', 'invalid', 422);
}
Expand Down
4 changes: 2 additions & 2 deletions tx/workers/validate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,11 +597,11 @@ class ValueSetChecker {
defLang.value = cs.defLang();
this.checkCanonicalStatus(path, op, cs, this.valueSet);
ver.value = cs.version();
contentMode.value = cs.contentMode;
contentMode.value = cs.contentMode();
let ctxt = cs.locate(code);
if (ctxt.context === null) {
unkCodes.push(system + '|' + version + '#' + code);
if (cs.contentMode !== 'complete') {
if (cs.contentMode() !== 'complete') {
result = true;
cause.value = 'code-invalid';
this.worker.opContext.addNote(this.valueSet, 'Not found in Incomplete Code System', this.indentCount);
Expand Down