Skip to content

Fix: correct shape check and torch.save argument order#1

Open
pawelpratyush wants to merge 1 commit into
Helix-Research-Lab:mainfrom
pawelpratyush:fix/pooler-shape-and-save-bugs
Open

Fix: correct shape check and torch.save argument order#1
pawelpratyush wants to merge 1 commit into
Helix-Research-Lab:mainfrom
pawelpratyush:fix/pooler-shape-and-save-bugs

Conversation

@pawelpratyush

Copy link
Copy Markdown

Bugs Fixed

  1. Undefined attribute

    • self.representations was referenced before assignment
    • Fixed by using self.representations_with_cls.shape
  2. Incorrect torch.save usage

    • Arguments were reversed:
      torch.save(save_path, cls_token)
    • Fixed to:
      torch.save(cls_token, save_path)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant