🧹 Refactor fetchRepositories to improve code health#453
Conversation
Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors src/lib/github.ts by extracting the GraphQL query and repository fetching logic from fetchRepositories into a dedicated helper function fetchRepositoriesGraphQL and a constant REPOSITORIES_GRAPHQL_QUERY. The reviewer noted that client-side filtering of fork repositories (!r.isFork) is redundant because the GraphQL query already specifies isFork: false, and suggested simplifying the filter to only remove potential null or undefined nodes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| throw new UserNotFoundError(username); | ||
| } | ||
|
|
||
| const repos = data.user.repositories.nodes.filter((r) => !r.isFork); |
There was a problem hiding this comment.
Since the GraphQL query REPOSITORIES_GRAPHQL_QUERY already specifies isFork: false in its arguments, the GitHub API will not return any fork repositories. Therefore, filtering the nodes with !r.isFork is redundant. You can simplify this by just filtering out any potential null/undefined nodes using filter(Boolean).
| const repos = data.user.repositories.nodes.filter((r) => !r.isFork); | |
| const repos = data.user.repositories.nodes.filter(Boolean); |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1 participant
🎯 What: Extracted the GraphQL query and mapping logic from
fetchRepositoriesinto helper variables and functions.💡 Why:
fetchRepositorieswas getting overly long, hindering readability and maintainability.✅ Verification: Verified that existing unit tests (
npm run test) continue to pass after the refactoring. Visually inspected diff to ensure no functionality is broken.✨ Result: Improved separation of concerns, maintaining exactly the same behavior while making
fetchRepositoriesshorter and more readable.PR created automatically by Jules for task 883741474502430235 started by @is0692vs
Greptile Summary
GraphQLクエリ文字列をモジュールレベルの定数
REPOSITORIES_GRAPHQL_QUERYへ、API呼び出し・ユーザー存在確認・フォーク除外・データ変換の各ロジックをfetchRepositoriesGraphQLヘルパー関数へ抽出するリファクタリングです。fetchRepositories本体の可読性が向上し、動作は完全に同一です。REPOSITORIES_GRAPHQL_QUERYは静的文字列定数としてモジュールロード時に一度だけ評価されるため、インデント変更もGraphQLパーサには影響しません。fetchRepositoriesGraphQLは非公開ヘルパーとして正しくモジュールスコープに閉じており、エクスポートはされていません。Confidence Score: 5/5
純粋なリファクタリングであり、動作変更なし。安全にマージ可能です。
変更はすべて src/lib/github.ts 内に閉じており、GraphQLクエリの内容・フィルタロジック・エラー処理はそのまま移動されたのみです。GraphQLはホワイトスペースを無視するため、インデントの変更も動作に影響しません。fetchRepositoriesGraphQL は非公開ヘルパーとして正しくスコープされており、fetchRepositories のキャッシュ動作も変わっていません。
特に注目が必要なファイルはありません。
Important Files Changed
REPOSITORIES_GRAPHQL_QUERYに、クエリ実行ロジックをfetchRepositoriesGraphQLヘルパー関数に抽出。動作の変更なし。Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["fetchRepositories(username, token?)"] --> B{token あり?} B -- No --> C["fetchRepositoriesREST(username)"] B -- Yes --> D["fetchRepositoriesGraphQL(username, token)"] D --> E["graphql<RepositoriesResponse>(REPOSITORIES_GRAPHQL_QUERY, token, ...)"] E --> F{data.user あり?} F -- No --> G["throw UserNotFoundError"] F -- Yes --> H["nodes.filter(r => !r.isFork)"] H --> I["processRepoData(repos)"] C --> J["restGet /users/:username/repos"] J --> K["processRepoData (REST版)"] I --> Z["RepositoryData を返す"] K --> Z%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD A["fetchRepositories(username, token?)"] --> B{token あり?} B -- No --> C["fetchRepositoriesREST(username)"] B -- Yes --> D["fetchRepositoriesGraphQL(username, token)"] D --> E["graphql<RepositoriesResponse>(REPOSITORIES_GRAPHQL_QUERY, token, ...)"] E --> F{data.user あり?} F -- No --> G["throw UserNotFoundError"] F -- Yes --> H["nodes.filter(r => !r.isFork)"] H --> I["processRepoData(repos)"] C --> J["restGet /users/:username/repos"] J --> K["processRepoData (REST版)"] I --> Z["RepositoryData を返す"] K --> ZReviews (1): Last reviewed commit: "🧹 Extract GraphQL logic from fetchRepos..." | Re-trigger Greptile