Skip to content

🧹 Refactor fetchRepositories to improve code health #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
is0692vs wants to merge 1 commit into
base: main
Choose a base branch
from
+42 −35
Open

🧹 Refactor fetchRepositories to improve code health #453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 42 additions & 35 deletions src/lib/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,47 @@ type RepositoriesResponse = {
} | null;
};

const REPOSITORIES_GRAPHQL_QUERY = `query($login: String!) {
user(login: $login) {
repositories(first: 100, ownerAffiliations: [OWNER, ORGANIZATION_MEMBER, COLLABORATOR], orderBy: {field: STARGAZERS, direction: DESC}, isFork: false, privacy: PUBLIC) {
totalCount
nodes {
name
description
url
stargazerCount
forkCount
isFork
primaryLanguage { name color }
languages(first: 10) {
edges {
size
node { name color }
}
}
repositoryTopics(first: 10) {
nodes {
topic { name }
}
}
}
}
}
}`;

async function fetchRepositoriesGraphQL(
username: string,
token: string
): Promise<RepositoryData> {
const data = await graphql<RepositoriesResponse>(REPOSITORIES_GRAPHQL_QUERY, token, { login: username });
if (!data.user) {
throw new UserNotFoundError(username);
}

const repos = data.user.repositories.nodes.filter((r) => !r.isFork);

@gemini-code-assist gemini-code-assist Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the GraphQL query REPOSITORIES_GRAPHQL_QUERY already specifies isFork: false in its arguments, the GitHub API will not return any fork repositories. Therefore, filtering the nodes with !r.isFork is redundant. You can simplify this by just filtering out any potential null/undefined nodes using filter(Boolean).

Suggested change
const repos = data.user.repositories.nodes.filter((r) => !r.isFork);
const repos = data.user.repositories.nodes.filter(Boolean);

return processRepoData(repos);
}

/**
* Task⑤: リポジトリ一覧・言語統計・トップリポジトリを取得
* 認証時: GraphQL (言語バイト数ベース), 未認証時: REST フォールバック
Expand All @@ -310,41 +351,7 @@ export const fetchRepositories = cache(async function fetchRepositories(
return fetchRepositoriesREST(username);
}

const query = `query($login: String!) {
user(login: $login) {
repositories(first: 100, ownerAffiliations: [OWNER, ORGANIZATION_MEMBER, COLLABORATOR], orderBy: {field: STARGAZERS, direction: DESC}, isFork: false, privacy: PUBLIC) {
totalCount
nodes {
name
description
url
stargazerCount
forkCount
isFork
primaryLanguage { name color }
languages(first: 10) {
edges {
size
node { name color }
}
}
repositoryTopics(first: 10) {
nodes {
topic { name }
}
}
}
}
}
}`;

const data = await graphql<RepositoriesResponse>(query, token, { login: username });
if (!data.user) {
throw new UserNotFoundError(username);
}

const repos = data.user.repositories.nodes.filter((r) => !r.isFork);
return processRepoData(repos);
return fetchRepositoriesGraphQL(username, token);
});

async function fetchRepositoriesREST(username: string): Promise<RepositoryData> {
Expand Down
Loading