feat(setup): add setup summary wizard step for MCP/skills/plugins overview (#3407)#3643
Open
cy2311 wants to merge 13 commits into
Open
feat(setup): add setup summary wizard step for MCP/skills/plugins overview (#3407)#3643cy2311 wants to merge 13 commits into
cy2311 wants to merge 13 commits into
Conversation
…references Part of Hmbown#3490 - add issue references to all single-hit #[allow(dead_code)] sites across 25 files. No functional changes.
…cking references Part of Hmbown#3490 - add issue references to #[allow(dead_code)] sites in 19 files across crates/tui/ and crates/tools/. No functional changes.
Part of Hmbown#3490 - 18 #[allow(dead_code)] sites in hooks.rs all had existing rationale comments; add issue reference.
…ec, goal_loop, prefix_cache Part of Hmbown#3490 - add issue references to #[allow(dead_code)] sites in core/ops.rs, tools/spec.rs, goal_loop.rs, prefix_cache.rs.
…3490 (batch 2) Part of Hmbown#3490 - annotates #[allow(dead_code)] sites in 29 files across the entire crates/tui/ codebase. Covers app.rs (27), palette.rs (24), hotbar/actions.rs (15), tools/registry.rs (14), prompt_zones.rs (13), tools/shell.rs (12), mcp.rs (11), runtime_threads.rs (10), core/events.rs (10), and 20 smaller files. Skips test files per AC. No functional changes.
Render the empty composer as a real blank cursor row followed by the ghost hint when space allows. This keeps terminal IME preedit text from being drawn over the placeholder while preserving the hint below the cursor. Keep the composer mouse-coordinate padding calculation aligned with the widget render path, and update the empty-composer cursor tests for wide, narrow, borderless, and IME-preedit layouts. Harvested from PR Hmbown#3634 by @nightt5879 Co-authored-by: Nightt <87569709+nightt5879@users.noreply.github.com>
…otations Part of Hmbown#3490 - removes duplicate inline comments introduced by sed replacements, and runs cargo fmt to fix formatting.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Thanks @cy2311 for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
Owner
|
Thanks for sending this in. I’m going to keep it out of the 0.8.65 release lane for now because CI is not green yet and the diff is broader than the setup-summary feature:
The setup-summary idea still looks like a good v0.8.67/#3407 direction; it just needs a narrower, formatted, green follow-up before we should merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the first step of the v0.8.67 setup wizard.
What
Part of #3407