ScratchNode v5 mobile visual reset + integrate scratchnode-public-rooms → main#498
Closed
HomenShum wants to merge 94 commits into
Closed
ScratchNode v5 mobile visual reset + integrate scratchnode-public-rooms → main#498HomenShum wants to merge 94 commits into
HomenShum wants to merge 94 commits into
Conversation
…scipline, cut first-viewport chrome Root cause was not "too many elements": :root had no type-size tokens (every component hardcoded sizes, so nothing ranked) and no accent/mono discipline (accent sprayed on logo/code/CTA/links; mono on human prose, not just IDs). Plus a flex-gap bug split the "ScratchNode" wordmark into "Scratch Node". - :root: add --fs-display/title/base/sub/label/mono type scale; reserve solid accent for the single primary action - header: fix wordmark flex-gap split; room code -> quiet muted mono chip; borderless menu icon - event strip: drop "0 FAQ"; gate L0 capture + event-mode to data-role=host (host/debug controls that leaked to attendees); de-mono to --ui - hero: drop duplicate joined count; "Disposable event brain" -> "Live event log - public wiki when it ends" (static + JS rewrite) - welcome banner: quiet (no accent card) + hidden on mobile - composer: placeholder -> "Message or /ask..." (fixes clipped placeholder, which came from JS not static markup); helpline 2 lines -> 1; privacy shows "Public" / "Private (lock)" text instead of an ambiguous open-lock glyph - empty state: remove giant "Ask the first question" CTA (composer is the CTA); "No messages yet" is the one 18px display element; copy teaches all 3 actions - keyboard: visualViewport --keyboard-offset pins the fixed composer above the keyboard; footer + welcome collapse while typing (data-input-focused) -> no more footer leaking behind the keyboard - menu: gate "Continue in NodeBench" to named users (was visible to anonymous guests under the hidden "Your notes" header); hide "Keyboard shortcuts" on mobile Presentational + copy only. Send/render path, seenIds dedup, and data-sn-live are untouched. Desktop layout unchanged (composer stays sticky-top). Verified: 49/49 chromium e2e (scratchnode-live-route-honesty 46 incl. home-v5-output-contract, + scratchnode-public-wiki 3); static launch scan PASS (0 blockers/warnings); before/after/keyboard/menu screenshots at 390px. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…-mobile-reset # Conflicts: # AGENT_COORDINATION.md # CHANGELOG/pages/proto-home-v5.md
Owner
Author
|
Superseded by #499 — the v5 mobile reset is re-landed as a clean 1-commit PR cherry-picked onto current main (no scratchnode-line baggage, no wiki-CTA conflict). This branch had an unresolvable concurrent-edit collision with Codex's live wiki-CTA rewrite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this integrates
Brings the
codex/scratchnode-public-roomsline intomain(92 commits / 56 files), headlined by the ScratchNode v5 mobile visual reset (top commit), plus the public-wiki → NodeBench link and the rest of the scratchnode public-rooms work already on this branch.Headline change — v5 mobile visual reset (
e0e96dc0)Root cause of the "prototype-y, crowded" mobile feel was not "too many elements" —
:roothad no type-size tokens (every component hardcoded sizes, nothing ranked) and no accent/mono discipline (accent sprayed everywhere; mono on human prose). Plus a flex-gap bug split the "Scratch Node" wordmark.:root(--fs-display/title/base/sub/label/mono); solid accent reserved for the one primary action (send). Mono reserved for machine IDs only (room code +/ask)..h-logo {flex; gap:6px}was splittingScratch/<span>Node</span>into two flex items → wrapped → renders ScratchNode.· 0 FAQ; gated●Eventmode +L0 Manualcapture (host/debug controls) todata-role="host"; de-mono'd.visualViewport→--keyboard-offsetpins the fixed composer above the keyboard; footer + welcome collapse while typing → no more footer leaking behind the keyboard.Presentational + copy only — send/render path,
seenIdsdedup, anddata-sn-liveare untouched. Desktop layout unchanged (composer stays sticky-top).Verification (local, against the edited file)
scratchnode-live-route-honesty(46, incl.home-v5-output-contract) +scratchnode-public-wiki(3). Specs self-servehome-v5.htmlfrom disk with Convex mocked.Required CI (Typecheck / Runtime smoke / Build) gates this PR.
🤖 Generated with Claude Code