chore: allow commonly used underscore-dangle exceptions#19
chore: allow commonly used underscore-dangle exceptions#19
Conversation
davidding
requested review from
alex-117,
cfrisoli,
craigayre,
david-mooney and
denisolvr
davidding
dismissed stale reviews from darkmavis1980 and denisolvr
via
ea6f127
|
@davidding just bear in mind that this will be only available in version 3.0.0 which is still in beta |
|
Also can you set the version as we don't have Jenkins doing it for us here? |
Co-authored-by: Craig Ayre <craig@softwayre.com>
davidding
force-pushed
the
feature/no-underscore-dangle-exceptions
branch
from
dbd8540 to
7b4c426
Compare
| { | ||
| "name": "@hs-web-team/eslint-config-node", | ||
| "version": "3.2.0", | ||
| "version": "3.2.1-0", |
There was a problem hiding this comment.
Something wrong here
There was a problem hiding this comment.
Can you just please add a preid of next
There was a problem hiding this comment.
Also, unless you want to test and iterate the changes to see if they work, you should just set the version directly, so this should be just 3.2.1
darkmavis1980
left a comment
darkmavis1980
left a comment
There was a problem hiding this comment.
Version is very wrong
@darkmavis1980 - How so? It is completely valid semver - https://semver.org/#spec-item-9 You had said:
That's what I did: 
We don't have a If we want to add a |
4 participants
No description provided.