Skip to content

chore: allow commonly used underscore-dangle exceptions #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidding wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: allow commonly used underscore-dangle exceptions #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4ad077
chore: allow commonly used underscore-dangle exceptions
Nov 27, 2025
7b4c426
fix: remove browser-specific exceptions
davidding Nov 27, 2025
8310197
build: do version prerelease
davidding Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,15 @@ const baseRules = {
'comma-dangle': ['warn', 'always-multiline'],
'arrow-parens': 0,
'no-plusplus': 0,
'no-underscore-dangle': 0,
'no-underscore-dangle': [
'error',
{
allow: [
'__dirname',
'__filename',
]
}
],
'no-confusing-arrow': 0,
'import/no-unresolved': 0,
'import/prefer-default-export': 0,
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@hs-web-team/eslint-config-node",
"version": "3.2.0",
"version": "3.2.1-0",
Copy link
Copy Markdown
Contributor

@darkmavis1980 darkmavis1980 Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something wrong here

Copy link
Copy Markdown
Author

@davidding davidding Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing wrong here 😄

Copy link
Copy Markdown
Contributor

@darkmavis1980 darkmavis1980 Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just please add a preid of next

Copy link
Copy Markdown
Contributor

@darkmavis1980 darkmavis1980 Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, unless you want to test and iterate the changes to see if they work, you should just set the version directly, so this should be just 3.2.1

"description": "HubSpot Marketing WebTeam shared configurations for ESLint, Prettier, Stylelint, and Cypress",
"main": "index.js",
"type": "module",
Expand Down