Conversation
Update assertions and assert message in ChangesFollowerTest testStart and testStop to validate 2 batches received.
mojito317
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Fix intermittent failures in
ChangesFollowerTesttestStartandtestStopFixes: s1167
Note: An existing issue is required before opening a PR.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
The test intermittently fails when 2 batches have been received, but not 3.
The assertion is written to expect at least 2 batches + 1 change, but the way changes are processed means this is equivalent to asserting 3 full batches received, where it is clear from the comment we expect on constrained test agents to be only into the third batch.
What is the new behavior?
Assert at least 2 complete batches processed
count >= 2*ChangesFollower.BATCH_SIZE.This makes the assertion match the expected behaviour.
Also change the assertion message to help with any future failures.
Does this PR introduce a breaking change?
Other information