Skip to content

test: fix intermittent failures #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ricellis merged 1 commit into from
Jun 12, 2025
Merged

test: fix intermittent failures #692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions modules/cloudant/src/test/java/com/ibm/cloud/cloudant/features/ChangesFollowerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* © Copyright IBM Corporation 2022, 2023. All Rights Reserved.
* © Copyright IBM Corporation 2022, 2025. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
Expand Down Expand Up @@ -366,8 +366,10 @@ void testStart() {
try {
// Run for 5 seconds against an infinite stream
long count = testFollowerOnThread(testFollower, ChangesFollower.Mode.LISTEN, false, Duration.ofSeconds(5L));
// Even on a slow test machine we should at least get into the third batch, but hard to predict total changes
Assert.assertTrue(count > 2*ChangesFollower.BATCH_SIZE + 1, "There should be some changes.");
// Even on a slow test machine we should at least get two batches, but hard to predict total changes
long expectedMinChanges = 2 * ChangesFollower.BATCH_SIZE;
Assert.assertTrue(count >= expectedMinChanges,
String.format("Expected at least %d changes, but found only %d.", expectedMinChanges, count));
} catch(Exception e) {
Assert.fail("There should be no exception.", e);
}
Expand Down Expand Up @@ -470,8 +472,10 @@ void testStop() {
try {
// Run for 5 seconds against an infinite stream
long count = testFollowerOnThread(testFollower, ChangesFollower.Mode.FINITE, false, Duration.ofSeconds(5L));
// Even on a slow test machine we should at least get into the third batch, but hard to predict total changes
Assert.assertTrue(count > 2*ChangesFollower.BATCH_SIZE + 1, "There should be some changes.");
// Even on a slow test machine we should at least get two batches, but hard to predict total changes
long expectedMinChanges = 2 * ChangesFollower.BATCH_SIZE;
Assert.assertTrue(count >= expectedMinChanges,
String.format("Expected at least %d changes, but found only %d.", expectedMinChanges, count));
} catch(Exception e) {
Assert.fail("There should be no exception.", e);
}
Expand Down