wip - add run start metadata #36
Conversation
Tom-Willemsen
left a comment
Tom-Willemsen
left a comment
There was a problem hiding this comment.
Thanks for putting this together - as expected, trying to write this down formally has raised a few questions!
| "num_periods": { | ||
| "description": "The total number of periods for this run", | ||
| "type": "integer" | ||
| }, |
There was a problem hiding this comment.
Question: if we say we have 5 periods, will those periods be labelled 0-4 or 1-5?
There was a problem hiding this comment.
periods are 1-indexed aren't they?
There was a problem hiding this comment.
In the ICP yes. I'm fine with either approach as long as we're explicit about it somewhere.
run_start_metadata_schema.json
Outdated
| "num_time_channels": { | ||
| "description": "The total number of time channels for this run", | ||
| "type":"integer" | ||
| }, |
There was a problem hiding this comment.
If we're supporting multiple time regimes, a single num_time_channels might be ambiguous. To discuss when we start to formalize what TCBs look like in a streaming world.
Maybe this is really a max_time_channels?
run_start_metadata_schema.json
Outdated
| "type": "number" | ||
| }, | ||
| "mode": { | ||
| "enum": ["dT = C", "dT/T = C", "dT/T**2 = C", "Shifted"] |
There was a problem hiding this comment.
As discussed - also want to allow for TCB files (or in other words arbitrary bin boundaries)
There was a problem hiding this comment.
yes, but do they need to be in this metadata or can kafka_dae_control just parse them and put them in here?
There was a problem hiding this comment.
i think they just want to be a parsed list.
| }, | ||
| "vetos": { | ||
| "description": "The vetos for this run", | ||
| "type": "array", |
There was a problem hiding this comment.
Let's clarify with DSG what form the vetos will be streamed in before commiting to a representation here.
No description provided.