-
Notifications
You must be signed in to change notification settings - Fork 0
wip - add run start metadata #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rerpha
wants to merge
3
commits into
main
Choose a base branch
from
add_rs_metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://github.com/ISISComputingGroup/DataStreaming/blob/main/run_start_metadata_schema.json", | ||
| "title": "run_start_metadata_schema", | ||
| "description": "Schema for run start metadata used at ISIS for kafka_dae_diagnostics", | ||
| "type": "object", | ||
| "properties": { | ||
| "num_periods": { | ||
| "description": "The total number of periods for this run, 1 indexed.", | ||
| "type": "integer" | ||
| }, | ||
| "max_time_channels": { | ||
| "description": "The maximum number of time channels for this run.", | ||
| "type": "integer" | ||
| }, | ||
| "time_regimes": { | ||
| "description": "The time regimes for this run.", | ||
| "type": "array", | ||
| "minItems": 1, | ||
| "items": { | ||
| "type": "array", | ||
| "description": "time regime rows", | ||
| "items": { | ||
| "$comment": "Either linear time regime rows, or an arbitrary list of bin-edges.", | ||
| "oneOf": [ | ||
| { | ||
| "type": "object", | ||
| "description": "time regime row", | ||
| "properties": { | ||
| "from": { | ||
| "type": "number" | ||
| }, | ||
| "to": { | ||
| "type": "number" | ||
| }, | ||
| "steps": { | ||
| "type": "number" | ||
| }, | ||
| "mode": { | ||
| "enum": [ | ||
| "dT = C", | ||
| "dT/T = C", | ||
| "dT/T**2 = C", | ||
| "Shifted" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "type": "integer" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "vetos": { | ||
| "description": "The vetos for this run", | ||
| "type": "array", | ||
| "minItems": 1, | ||
| "items": { | ||
| "type": "object", | ||
| "properties": { | ||
| "name": { | ||
| "type": "string" | ||
| }, | ||
| "enabled": { | ||
| "type": "boolean" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "required": [ | ||
| "num_periods", | ||
| "num_time_channels", | ||
| "time_regimes", | ||
| "vetos" | ||
| ] | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's clarify with DSG what form the vetos will be streamed in before commiting to a representation here.