test(miner): mirror shouldReenter ceilings under root vitest for Codecov (#8347)

[claytonlin1110]

Summary

• Add test/unit/loop-reentry-policy.test.ts, a root vitest mirror of the existing engine node:test suite for shouldReenter, so Codecov codecov/patch can see packages/loopover-engine/src/miner/loop-reentry-policy.ts.
• Imports via the engine barrel (../../packages/loopover-engine/src/index), matching test/unit/calibration-dashboard.test.ts.
• No changes under packages/loopover-engine/src/** or packages/loopover-engine/test/**.

Closes #8347

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Test-only PR (new root vitest file). Locally verified: npx vitest run test/unit/loop-reentry-policy.test.ts (17 pass), coverage of loop-reentry-policy.ts at 100% statements/branches/lines, npm run typecheck, git diff --check, and npm audit --audit-level=moderate. No src/** production diff; remaining validate-code steps left to CI.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — test-only, no visible UI change.

State / title	JPG/PNG evidence
N/A

Notes

• Same Codecov blind-spot pattern as fix(ci): review-enrichment's real node:test coverage is invisible to Codecov (83 of 83 files effectively unmeasured) #6250 (review-enrichment node:test invisible to root vitest).
• Engine source and existing packages/loopover-engine/test/loop-reentry-policy.test.ts are untouched.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

Caution

🛑 LoopOver review result - fixes required

_{Review updated: 2026-07-24 14:49:30 UTC}

1 file · 1 AI reviewer · no blockers · CI failing · blocked

🛑 Suggested Action - Fix Blockers

Review summary
This PR adds a root-level vitest mirror of the existing engine node:test suite for shouldReenter, purely to get Codecov visibility into packages/loopover-engine/src/miner/loop-reentry-policy.ts, with no changes to source under packages/loopover-engine/src/** or its own test suite. The test cases are thorough, covering kill-switch precedence, circuit-breaker && short-circuiting, rate caps, default vs override thresholds, and multi-reason aggregation, matching the behavior implied by the shouldReenter contract used in loop-reentry.ts. It's a duplicative test file (mirroring another suite) but that duplication is the explicit, stated purpose of the PR, and it correctly imports through the engine barrel as other root vitest tests do.

Nits — 4 non-blocking

• The file duplicates an entire existing node:test suite verbatim in vitest syntax, which is acceptable for the stated Codecov-visibility goal but creates a second suite to keep in sync if shouldReenter's behavior changes.
• test/unit/loop-reentry-policy.test.ts:9-19 — baseCandidate omits maxConsecutiveDisengagements/maxReentriesPerHour/maxReentriesPerSession, relying on shouldReenter's own defaulting; worth a one-line comment noting that's intentional (to test default-threshold behavior) rather than an oversight.
• Consider a lightweight jsdoc or README note in test/unit/ clarifying that this file is a deliberate mirror of packages/loopover-engine/test/loop-reentry-policy.test.ts so future contributors don't delete it as a duplicate.
• If the engine suite changes assertions in the future, add a CI note or checklist reminder to keep both suites in lockstep.

CI checks failing

• validate
• validate-tests-merge

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8347
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 406 registered-repo PR(s), 254 merged, 92 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	claytonlin1110; Gittensor profile; 406 PR(s), 92 issue(s).
Improvement	ℹ️ Insufficient signal	risk: clean · value: insufficient-signal · LLM: minor

Linked issue satisfaction

Addressed
The PR adds test/unit/loop-reentry-policy.test.ts using vitest imports from the engine barrel, mirroring the existing node:test suite with kill-switch short-circuit, each ceiling's boundary and override cases, multiple-ceiling collection, outcome-gating, and the clean-pass case, without touching the restricted source/test files.

Review context

• Author: claytonlin1110
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 406 PR(s), 92 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Triage stale or unlinked PRs.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests-merge)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.