feat(calibration): record advisory-mode rule-fired signals too, tagged with the resolved gate mode

[JSONbored]

Summary

The corpus-starvation fix from adversarial-audit epic #8757. recordConfiguredGateBlockerSignals only recorded findings whose gate resolved to "block" — but every gate defaults to advisory/off, so the majority of real traffic (advisory findings a human actually saw) recorded nothing, and every downstream backtest corpus, reliability curve, and knob-loosening decision was built from the biased block-mode-only minority sample.

Changes

• src/rules/advisory.ts — isConfiguredGateBlocker is now a === "block" projection of a new resolveConfiguredGateMode(finding, policy) → "block" | "advisory" | "off": one source of truth, so the recorder and the gate can never drift. Every mode default is byte-identical to the old switch (verified by the 1,583 tests across the 20 gate/signal-adjacent suites). The recorder captures every non-"off" finding, tagged metadata.gateMode, so consumers can segment bot-actioned evidence from shown-to-a-human evidence. Notable resolutions: the advisory_only sub-floor AI demotion resolves "advisory" (a real finding a human saw, worth corpus evidence — never "off"); manifest_linked_issue_required composes the stricter of its two gates (block > advisory > off), preserving the original blocks-when-either-blocks semantics exactly.
• Consumer-segmentation audit (required by calibration: record rule-fired signals for advisory/off gate modes too, tagged with the resolved mode #8760, recorded in the recorder's doc comment): every current consumer is decided-case-driven — buildBacktestCorpus drops unpaired fires; computeRulePrecision, the reliability curve, and the knob evaluators run over that decided corpus; the rule-repeat alarm reads its own separately-namespaced composite ruleId and never sees these events. Advisory fires therefore sit inert until calibration: implicit-confirmation override signals for non-AI-judgment rules (merge-without-reversal => confirmed) #8761's implicit confirmations start pairing them (which carry their own basis tag for weighting). No existing metric shifts from this change alone.
• Additive only: no rewriting of recorded history; write posture stays best-effort (.catch(() => undefined)).
• linked_issue_scope_mismatch stays excluded (calibration: wire linked_issue_scope_mismatch into the shared signal-tracking module (fired + reversal) #8101 owns it); secret_leak raw-context exclusion unchanged (calibration: capture bounded raw context for the remaining isConfiguredGateBlocker codes, excluding secret_leak #8130) — it gains only the gateMode tag.

Test plan

• npm run typecheck — clean
• Recorder suite: 25/25, including new tests for advisory-mode recording, off-mode non-recording, the sub-floor advisory_only demotion tag, and the stricter-of-two-gates composition
• 1,583 tests green across all 20 suites touching evaluateGateCheck / the signal surface
• Changed line range: 0 uncovered statements, 0 uncovered branches (verified via istanbul JSON)

Closes #8760

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[github-actions]

Logic backtest

Replayed 0 historical case(s) for linked_issue_scope_mismatch through the base (a93ae0a) and head (2aebb5e) versions of its detection logic (corpus checksum 4f53cda18c2b).

Backtest comparison: linked_issue_scope_mismatch

Verdict: unchanged — no comparable axis moved.

Advisory only — this check never blocks merge (#8105).

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	loopover-ui	2aebb5e	Commit Preview URL Branch Preview URL	Jul 26 2026, 05:36 AM

[codecov]

❌ 3 Tests Failed:

Tests completed	Failed	Passed	Skipped
21179	3	21176	21

View the top 3 failed test(s) by shortest run time

test/unit/check-engine-parity-script.test.ts > check-engine-parity script > runEngineParityMain returns 0 for the real monorepo workspace

Stack Traces | 0.043s run time

AssertionError: expected 1 to be +0 // Object.is equality

- Expected
+ Received

- 0
+ 1

 ❯ test/unit/check-engine-parity-script.test.ts:798:48

test/unit/check-engine-parity-script.test.ts > check-engine-parity script > engine version skew > uses default version readers against the real monorepo workspace

Stack Traces | 0.0532s run time

AssertionError: expected [ Array(1) ] to deeply equal []

- Expected
+ Received

- []
+ [
+   "Gate-decision logic change in src/rules/advisory.ts requires either:
+   • a matching edit to the other twin (.../src/advisory/gate-advisory.ts), or
+   • a version bump in packages/loopover-engine/package.json (currently 3.14.1 vs base 3.14.1).",
+ ]

 ❯ test/unit/check-engine-parity-script.test.ts:785:31

test/unit/check-engine-parity-script.test.ts > check-engine-parity script > prints a clean summary and exits 0 for the real repo state when run as a subprocess

Stack Traces | 0.904s run time

Error: Command failed: .../loopover/node_modules/.bin/tsx scripts/check-engine-parity.ts
Engine-parity check found 1 issue(s):
Gate-decision logic change in src/rules/advisory.ts requires either:
  • a matching edit to the other twin (.../src/advisory/gate-advisory.ts), or
  • a version bump in packages/loopover-engine/package.json (currently 3.14.1 vs base 3.14.1).

 ❯ test/unit/check-engine-parity-script.test.ts:803:20

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { status: 1, signal: null, output: [ null, '', 'Engine-parity check found 1 issue(s):\nGate-decision logic change in src/rules/advisory.ts requires either:\n  • a matching edit to the other twin (.../src/advisory/gate-advisory.ts), or\n  • a version bump in packages/loopover-engine/package.json (currently 3.14.1 vs base 3.14.1).\n' ], pid: 7145, stdout: '', stderr: 'Engine-parity check found 1 issue(s):\nGate-decision logic change in src/rules/advisory.ts requires either:\n  • a matching edit to the other twin (.../src/advisory/gate-advisory.ts), or\n  • a version bump in packages/loopover-engine/package.json (currently 3.14.1 vs base 3.14.1).\n' }

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}