fix(db): drop stale migration-90 grandfather entry - #8968
Closed
joaovictor91123 wants to merge 1 commit into
Closed
Conversation
0090_pull_request_detail_sync_head_sha was renumbered to 0092; keep KNOWN_MIGRATION_DUPLICATES and the check-migrations success summary aligned with the real files on disk. Point the live-recheck grandfather fixture at the still-shipped 0156 pair. Closes JSONbored#8897
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
Author
|
Closing - validate-tests failed again on the recurring unrelated |
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0090entry fromKNOWN_MIGRATION_DUPLICATES—0090_pull_request_detail_sync_head_shawas renumbered to0092, so only0090_contributor_cap_labelremains on disk.check-migrationsheader comment, collision unit coverage, and the success-summary assertion (4 grandfathered duplicates).queue-3.test.tsto the still-shipped0156pair.Closes #8897
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
miner-worktree-allocator-collisions(distinct-path acquire race); the grandfather summary assertion itself passed on that run.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — no visible UI changes.
Notes
main, plus the queue-3 fixture retarget so it no longer cites the removed 0090 grandfather pair).