Skip to content

fix(db): drop stale migration-90 grandfather entry - #8968

Closed
joaovictor91123 wants to merge 1 commit into
JSONbored:mainfrom
joaovictor91123:fix/stale-migration-duplicates-8897-v4
Closed

fix(db): drop stale migration-90 grandfather entry#8968
joaovictor91123 wants to merge 1 commit into
JSONbored:mainfrom
joaovictor91123:fix/stale-migration-duplicates-8897-v4

Conversation

@joaovictor91123

Copy link
Copy Markdown
Contributor

Summary

  • Drop the stale 0090 entry from KNOWN_MIGRATION_DUPLICATES0090_pull_request_detail_sync_head_sha was renumbered to 0092, so only 0090_contributor_cap_label remains on disk.
  • Update check-migrations header comment, collision unit coverage, and the success-summary assertion (4 grandfathered duplicates).
  • Retarget the live-recheck grandfather fixture in queue-3.test.ts to the still-shipped 0156 pair.

Closes #8897

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • Full suite not re-run locally (Node 24 vs engines Node 22). Change is confined to migration grandfather list + unit tests; CI is source of truth. Replaces fix(db): drop stale migration-90 grandfather entry #8949, which failed solely on an unrelated flake in miner-worktree-allocator-collisions (distinct-path acquire race); the grandfather summary assertion itself passed on that run.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — no visible UI changes.

Notes

0090_pull_request_detail_sync_head_sha was renumbered to 0092; keep KNOWN_MIGRATION_DUPLICATES and the check-migrations success summary aligned with the real files on disk. Point the live-recheck grandfather fixture at the still-shipped 0156 pair.

Closes JSONbored#8897
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
21962 1 21961 21
View the top 1 failed test(s) by shortest run time
test/unit/miner-worktree-allocator-collisions.test.ts > loopover-miner worktree allocator collisions (#4298) > rejects excess simultaneous cross-process acquire calls at the concurrency cap
Stack Traces | 0.376s run time
AssertionError: expected [ …(3) ] to have a length of 2 but got 3

- Expected
+ Received

- 2
+ 3

 ❯ test/unit/miner-worktree-allocator-collisions.test.ts:162:23

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@joaovictor91123

Copy link
Copy Markdown
Contributor Author

Closing - validate-tests failed again on the recurring unrelated miner-worktree-allocator-collisions flake. Switching to a different issue for now; #8897 remains open for a later retry.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(db): stale KNOWN_MIGRATION_DUPLICATES entry for migration 90 references a file that no longer exists

1 participant