fix(queue): correct maybeApplyManifestPolicyGate's "three"->"two" enforceable-findings comments - #9337
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
…orceable-findings comments maybeApplyManifestPolicyGate's JSDoc and inline comment both said it pushes "three enforceable policy findings", but its policyCodes set (and resolveConfiguredGateMode in advisory.ts) only has two. Update both comments to "two enforceable policy findings" to match the actual code. Comment-only; no logic changed. Closes JSONbored#9295 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-27 13:31:00 UTC
Review summary Nits — 4 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
maybeApplyManifestPolicyGate's JSDoc and inline comment both said it pushes "three enforceablepolicy findings", but its actual
policyCodesset — andresolveConfiguredGateModeinsrc/rules/advisory.ts— only has two. Both comments are updated to "two enforceable policyfindings" so the docs match the code.
policyCodesand all logic are unchanged.Test plan
grep "three enforceable" src/queue/processors.tsreturns zero occurrences after the fix..gittensory.yml.example/config/examples/gittensory.full.ymluntouched (already fixed by fix(config): stop documenting the retired blockedPaths key as a live feature #5304).Closes #9295