Skip to content

fix(queue): correct maybeApplyManifestPolicyGate's "three"->"two" enforceable-findings comments - #9337

Closed
kai392 wants to merge 1 commit into
JSONbored:mainfrom
kai392:fix/critical-issue-manifest-gate-comment
Closed

fix(queue): correct maybeApplyManifestPolicyGate's "three"->"two" enforceable-findings comments#9337
kai392 wants to merge 1 commit into
JSONbored:mainfrom
kai392:fix/critical-issue-manifest-gate-comment

Conversation

@kai392

@kai392 kai392 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

maybeApplyManifestPolicyGate's JSDoc and inline comment both said it pushes "three enforceable
policy findings", but its actual policyCodes set — and resolveConfiguredGateMode in
src/rules/advisory.ts — only has two. Both comments are updated to "two enforceable policy
findings" so the docs match the code. policyCodes and all logic are unchanged.

Test plan

  • Comment-only change — no executable logic modified, so no test changes are needed (no behavior changed; no placeholder/stub test added, per the issue's instruction).
  • grep "three enforceable" src/queue/processors.ts returns zero occurrences after the fix.
  • .gittensory.yml.example / config/examples/gittensory.full.yml untouched (already fixed by fix(config): stop documenting the retired blockedPaths key as a live feature #5304).

Closes #9295

@kai392
kai392 requested a review from JSONbored as a code owner July 27, 2026 13:20
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

…orceable-findings comments

maybeApplyManifestPolicyGate's JSDoc and inline comment both said it pushes "three enforceable policy
findings", but its policyCodes set (and resolveConfiguredGateMode in advisory.ts) only has two. Update
both comments to "two enforceable policy findings" to match the actual code. Comment-only; no logic
changed.

Closes JSONbored#9295

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
3931 2 3929 11
View the top 2 failed test(s) by shortest run time
test/unit/selfhost-pg-retention.test.ts > runRetentionPrune + processJob on the Postgres backend (#977) > processJob prune-retention deletes eligible rows and records a success audit event on Postgres
Stack Traces | 0.00419s run time
AssertionError: expected 3 to be +0 // Object.is equality

- Expected
+ Received

- 0
+ 3

 ❯ test/unit/selfhost-pg-retention.test.ts:119:44
test/unit/selfhost-pg-retention.test.ts > pruneExpiredRecords on the Postgres backend (#977) > deletes across multiple bounded batches and stops at the per-table cap, same as the SQLite path
Stack Traces | 0.0092s run time
AssertionError: expected +0 to be 4 // Object.is equality

- Expected
+ Received

- 4
+ 0

 ❯ test/unit/selfhost-pg-retention.test.ts:76:33

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 27, 2026
@loopover-orb

loopover-orb Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Caution

🛑 LoopOver review result - fixes required

Review updated: 2026-07-27 13:31:00 UTC

1 file · 1 AI reviewer · no blockers · CI failing · unstable

🛑 Suggested Action - Fix Blockers

Review summary
This is a pure comment-fix: two doc/inline comments in maybeApplyManifestPolicyGate that said 'three enforceable policy findings' are corrected to 'two', matching the actual policyCodes set. No executable logic is touched, so the change is inherently safe and the stated no-test-changes plan is appropriate. The PR closes issue #9295 and stays tightly scoped to the described fix.

Nits — 4 non-blocking
  • The FAILED validate-tests/validate checks have no detail provided, and given this branch is 1 commit behind default, the more likely explanation is drift from a recent default-branch change rather than anything in this comment-only diff — worth rebasing to confirm before merge.
  • The long-file size smell on src/queue/processors.ts (9344 lines) is pre-existing and unrelated to this diff; not something to fix here.
  • Consider a repo-wide grep for other stale 'three enforceable' or similar count references near policyCodes to make sure no other comment/doc drifted the same way.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

CI checks failing

  • validate
  • validate-tests

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #9295
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 96 registered-repo PR(s), 50 merged, 6 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kai392; Gittensor profile; 96 PR(s), 6 issue(s).
Improvement ℹ️ None detected risk: low · value: none · LLM: minor
Linked issue satisfaction

Addressed
The diff updates both the JSDoc and inline comment occurrences of "three enforceable policy findings" to "two" in maybeApplyManifestPolicyGate, leaves policyCodes and logic untouched, and the PR description states the grep check and lack of needed test changes as required.

Review context
  • Author: kai392
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, Cuda, JavaScript, Kotlin, Perl, TypeScript, Vue
  • Official Gittensor activity: 96 PR(s), 6 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Triage stale or unlinked PRs.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb

loopover-orb Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

queue: maybeApplyManifestPolicyGate's doc comments say 'three' enforceable policy findings, code has two

2 participants