fix(queue): correct maybeApplyManifestPolicyGate's 'three'->'two' enforceable-findings comments - #9388
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
…orceable-findings comments maybeApplyManifestPolicyGate's JSDoc and inline comment both said it pushes "three enforceable policy findings", but its policyCodes set (and resolveConfiguredGateMode in advisory.ts) only has two. Update both comments to "two enforceable policy findings" to match the actual code. Comment-only; no logic changed. Closes JSONbored#9295 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9388 +/- ##
===========================================
- Coverage 89.46% 76.45% -13.02%
===========================================
Files 836 276 -560
Lines 109588 61425 -48163
Branches 26096 7412 -18684
===========================================
- Hits 98046 46964 -51082
- Misses 10279 14076 +3797
+ Partials 1263 385 -878
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-27 15:43:12 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Closes #9295
What
maybeApplyManifestPolicyGatepushes only the two enforceable manifest policy findings, but two of its doc comments described it as "the three enforceable policy findings" — a stale count. This corrects both comments to "two".Note this is distinct from the nearby
/* v8 ignore */comment about "the three manifest policy findings always carry an action" — there genuinely are three findings, but only two are enforceable (pushed by this gate). That comment is a different, correct statement and is left unchanged.Tests
No test change: this is a comment-only correction with no runtime or type effect, as the issue's Definition of Done specifies. Diff is scoped to the two comment lines in
src/queue/processors.ts.