Skip to content

fix(queue): correct maybeApplyManifestPolicyGate's 'three'->'two' enforceable-findings comments - #9388

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
kai392:fix/critical-issue-manifest-gate-comment
Jul 27, 2026
Merged

fix(queue): correct maybeApplyManifestPolicyGate's 'three'->'two' enforceable-findings comments#9388
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
kai392:fix/critical-issue-manifest-gate-comment

Conversation

@kai392

@kai392 kai392 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Closes #9295

What

maybeApplyManifestPolicyGate pushes only the two enforceable manifest policy findings, but two of its doc comments described it as "the three enforceable policy findings" — a stale count. This corrects both comments to "two".

Note this is distinct from the nearby /* v8 ignore */ comment about "the three manifest policy findings always carry an action" — there genuinely are three findings, but only two are enforceable (pushed by this gate). That comment is a different, correct statement and is left unchanged.

Tests

No test change: this is a comment-only correction with no runtime or type effect, as the issue's Definition of Done specifies. Diff is scoped to the two comment lines in src/queue/processors.ts.

@kai392
kai392 requested a review from JSONbored as a code owner July 27, 2026 15:31
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

…orceable-findings comments

maybeApplyManifestPolicyGate's JSDoc and inline comment both said it pushes "three enforceable policy
findings", but its policyCodes set (and resolveConfiguredGateMode in advisory.ts) only has two. Update
both comments to "two enforceable policy findings" to match the actual code. Comment-only; no logic
changed.

Closes JSONbored#9295

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.45%. Comparing base (83b6867) to head (1474306).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9388       +/-   ##
===========================================
- Coverage   89.46%   76.45%   -13.02%     
===========================================
  Files         836      276      -560     
  Lines      109588    61425    -48163     
  Branches    26096     7412    -18684     
===========================================
- Hits        98046    46964    -51082     
- Misses      10279    14076     +3797     
+ Partials     1263      385      -878     
Flag Coverage Δ
backend 94.79% <ø> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/queue/processors.ts 94.79% <ø> (ø)

... and 698 files with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 27, 2026
@loopover-orb

loopover-orb Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-27 15:43:12 UTC

1 file · 1 AI reviewer · no blockers · readiness 90/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a comment-only fix correcting two stale doc comments in `maybeApplyManifestPolicyGate` from 'three' to 'two' enforceable findings, matching the PR description and closing #9295. The diff touches only comment text on two locations (JSDoc and inline comment), has no runtime or type effect, and CI passed on all checks. This is about as low-risk and well-scoped as a change can be.

Nits — 4 non-blocking
  • No test change is expected or needed for a comment-only correction, so the 'zero test-path evidence' flag from the external brief is a false positive here — nothing to act on.
  • The long-file size smell on src/queue/processors.ts (9344 lines) predates this PR and isn't something this 2-line diff should be expected to address.
  • Consider a lint rule or periodic doc-comment audit for this file given its size, so stale counts like this don't recur, though that's out of scope for this PR.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #9295
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ⚠️ 20/25 Preflight is ready, but the PR body does not name the validation run.
Contributor workload ✅ 10/10 Author activity: 96 registered-repo PR(s), 50 merged, 6 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kai392; Gittensor profile; 96 PR(s), 6 issue(s).
Improvement ℹ️ None detected risk: low · value: none · LLM: minor
Linked issue satisfaction

Addressed
The PR updates both the JSDoc and inline comment occurrences of 'three enforceable policy findings' to 'two', exactly matching the two required deliverables, and explicitly notes no test changes are needed for this comment-only fix.

Review context
  • Author: kai392
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, Cuda, JavaScript, Kotlin, Perl, TypeScript, Vue
  • Official Gittensor activity: 96 PR(s), 6 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Add validation command/output.
  • Then work through the remaining 1 step in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 6ace1aa into JSONbored:main Jul 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

queue: maybeApplyManifestPolicyGate's doc comments say 'three' enforceable policy findings, code has two

2 participants