Skip to content

fix(queue): correct maybeApplyManifestPolicyGate's 'three'->'two' enforceable-findings comments #9388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 27, 2026
+2 −2
Merged

fix(queue): correct maybeApplyManifestPolicyGate's 'three'->'two' enforceable-findings comments #9388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/queue/processors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9315,7 +9315,7 @@ export function reviewDurationMsSince(startedAt: string | null, nowMs: number):
/**
* Focus-manifest policy gate (#555, opt-in via `manifestPolicyGateMode`). Reloads the CACHED manifest (the
* settings resolver discards the raw manifest, but loadRepoFocusManifest is cached so this is cheap),
* recomputes the guidance over the PR's changed files, and pushes ONLY the three enforceable policy findings
* recomputes the guidance over the PR's changed files, and pushes ONLY the two enforceable policy findings
* onto the advisory so isConfiguredGateBlocker can block under `manifestPolicy: block`. Also runs the E2E
* test-generation auto-trigger (#4196, part of the #4189 epic) — see the inline comments below for the full
* rationale of each step. `manifestPolicyGateMode: "off"` (the default) is a no-op, so the advisory/gate
Expand All @@ -9338,7 +9338,7 @@ async function maybeApplyManifestPolicyGate(
): Promise<void> {
// Focus-manifest policy (#555, opt-in via manifestPolicyGateMode). Reload the CACHED manifest (the
// settings resolver discards the raw manifest, but loadRepoFocusManifest is cached so this is cheap),
// recompute the guidance over the PR's changed files, and push ONLY the three enforceable policy
// recompute the guidance over the PR's changed files, and push ONLY the two enforceable policy
// findings into the advisory so isConfiguredGateBlocker can block under manifestPolicy: block.
if (args.settings.manifestPolicyGateMode !== "off") {
// `gateFiles` is threaded in by the ONLY caller (maybePublishPrPublicSurface) already resolved via
Expand Down