fix(ci): unbreak main — two checkers in test:ci are failing on a clean tree - #9944
Merged
Conversation
#9938 exported AUTOMATION_ENACTING_ACTIONS and AUTOMATION_HOLD_ACTION, but AUTOMATION_COUNTED_ACTIONS is the surface both the fold and the read actually consume, so the other two are referenced only inside their own module. dead-exports:check runs in test:ci and fails on them. Module-private now; the exported vocabulary and every behaviour are unchanged.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Contributor
|
Important 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏳ LoopOver is waiting…LoopOver has seen this pull request and is waiting on CI checks to finish before reviewing it. This comment will update once the review runs. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟨 Waiting |
…change A merge changed package-lock.json without re-running replay-runner-manifest:write, so the committed packageLockSha256 no longer matched the committed lockfile and replay-runner-manifest:check -- which runs in test:ci -- failed on clean main. Regenerated; only the lockfile hash and the rolled-up digest move.
JSONbored
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9944 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 928 928
Lines 113657 113657
Branches 27406 27406
=======================================
Hits 104427 104427
Misses 7931 7931
Partials 1299 1299
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6 tasks
This was referenced Jul 31, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red on two checkers that both run intest:ci. Verified by running them against a clean checkout oforigin/main, not just against my branch.1.
dead-exports:checkMy merged #9938 exported
AUTOMATION_ENACTING_ACTIONSandAUTOMATION_HOLD_ACTION.AUTOMATION_COUNTED_ACTIONSis the surface both the fold and the SQL read consume, so those two are referenced only inside their own module — exactly what that checker exists to catch.Made module-private. The exported vocabulary and every behaviour are unchanged;
test/unit/automation-rate.test.tspasses unmodified (24/24).My fault: I ran the checkers that seemed related to the change rather than the ones that actually gate it.
2.
replay-runner-manifest:checkPre-existing and unrelated to me. A merge changed
package-lock.jsonwithout re-runningreplay-runner-manifest:write, so the committedpackageLockSha256stopped matching the committed lockfile:Regenerated. Only the lockfile hash and the rolled-up digest move — no source-file hash, base image, or Dockerfile hash changes.
Note
Both were found by a full sweep of every
check-*script rather than a selected subset, which is the process I'm now using before pushing. That sweep is also what motivated #9945.