refactor(fleet): use shared derived repo validation#27
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16a403d7dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if python3 -c "import aio_fleet" >/dev/null 2>&1; then | ||
| exec python3 -m aio_fleet.cli "${args[@]}" |
There was a problem hiding this comment.
This change makes scripts/validate-derived-repo.sh fail in a normal checkout unless aio_fleet is preinstalled or a sibling aio-fleet repo exists, which is a regression from the previous self-contained validator behavior. In this repository as committed, running bash scripts/validate-derived-repo.sh . exits with the new error path, so local validation (and any CI job that only installs this repo’s own dev deps) breaks immediately instead of validating derived-repo contents.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79accd61e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if python3 -c "import aio_fleet" >/dev/null 2>&1; then | ||
| exec python3 -m aio_fleet.cli "${args[@]}" |
There was a problem hiding this comment.
The early import aio_fleet check immediately execs the installed module and never reaches the AIO_FLEET_PATH fallback logic, so a stale or partial site-packages install can break validation even when a valid local checkout is explicitly provided. In practice, if PYTHONPATH contains an aio_fleet package without aio_fleet.cli, this path exits with No module named aio_fleet.cli instead of using the checkout discovered later in the script, which defeats the documented local-override behavior.
Useful? React with 👍 / 👎.
1 participant
Summary
aio-fleetshimaio-fleet@6cb527a4cccd624ad73447b6b73cda9b56b4c9c7What changed
scripts/validate-derived-repo.shnow delegates toaio-fleet validate-derivedWhy
aio-fleetValidation
python3 scripts/validate-template.py --allbash scripts/validate-derived-repo.sh .git diff --checkactionlint -shellcheck '' -pyflakes '' -ignore 'SC2129' .github/workflows/*.ymlpython -m aio_fleet verify-caller --repo unraid-aio-template --repo-path /Users/shadowbook/Documents/unraid-aio-template --ref 6cb527a4cccd624ad73447b6b73cda9b56b4c9c7