refactor(fleet): use shared derived repo validation #27
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,120 +1,38 @@ | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| repo_root="${1:-.}" | ||
| strict_placeholders="${STRICT_PLACEHOLDERS:-false}" | ||
|
|
||
| args=(validate-derived --repo-path "${repo_root}") | ||
| if [[ ${strict_placeholders} == "true" ]]; then | ||
| args+=(--strict-placeholders) | ||
| fi | ||
|
|
||
| if python3 -c "import aio_fleet" >/dev/null 2>&1; then | ||
| exec python3 -m aio_fleet.cli "${args[@]}" | ||
|
Comment on lines
+12
to
+13
There was a problem hiding this comment.
The early Useful? React with 👍 / 👎. |
||
| fi | ||
|
|
||
| script_dir="$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)" | ||
| candidate_roots=() | ||
| if [[ -n ${AIO_FLEET_PATH-} ]]; then | ||
| candidate_roots+=("${AIO_FLEET_PATH}") | ||
| fi | ||
| candidate_roots+=( | ||
| "${script_dir}/../../aio-fleet" | ||
| "${script_dir}/../../../aio-fleet" | ||
| "../aio-fleet" | ||
| "../../aio-fleet" | ||
| ) | ||
|
|
||
| for candidate in "${candidate_roots[@]}"; do | ||
| if [[ -d ${candidate}/src/aio_fleet ]]; then | ||
| PYTHONPATH="${candidate}/src${PYTHONPATH:+:${PYTHONPATH}}" exec python3 -m aio_fleet.cli "${args[@]}" | ||
| fi | ||
| done | ||
|
|
||
| cat >&2 <<'EOF' | ||
| template validation error: aio-fleet is required for derived repo validation. | ||
| Install aio-fleet or set AIO_FLEET_PATH to a local aio-fleet checkout. | ||
| EOF | ||
| exit 1 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes
scripts/validate-derived-repo.shfail in a normal checkout unlessaio_fleetis preinstalled or a siblingaio-fleetrepo exists, which is a regression from the previous self-contained validator behavior. In this repository as committed, runningbash scripts/validate-derived-repo.sh .exits with the new error path, so local validation (and any CI job that only installs this repo’s own dev deps) breaks immediately instead of validating derived-repo contents.Useful? React with 👍 / 👎.