feat(plugin): self-contained mode engine — plugin works without MCP server (#1192)#1194
Merged
Conversation
…erver (#1192) Add ModeEngine class that reads .ai-rules/ files directly and outputs complete PLAN/ACT/EVAL/AUTO mode instructions. The hook no longer requires the MCP server to be running for basic mode functionality. parse_mode MCP is suggested as optional enhancement.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…tests - Remove duplicate AgentStack interface (specialist_agents vs specialists conflict) - Unify on specialist_agents to match JSON schema and stack files - Update agent-stack.service, agent.handler, and their specs - Update e2e tests for new self-contained mode engine output format
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Conductor Review — APPROVE
CI: 25/25 ALL PASS
Review: APPROVE — 0 issues
Plan Verification (#1192):
- mode_engine.py created with ModeEngine class
- Rules path resolution (env → project → plugin → package)
- PLAN/ACT/EVAL/AUTO mode templates generated
- user-prompt-submit.py modified for self-contained output
- MCP parse_mode as optional enhancement
- Multilingual keyword support maintained
- E2E tests updated for new output format
- AgentStack type conflict resolved (specialist_agents unified)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModeEngineclass (hooks/lib/mode_engine.py) that generates complete PLAN/ACT/EVAL/AUTO mode instructions without requiring MCP serveruser-prompt-submit.pyto use ModeEngine for self-contained mode output instead of mandatingparse_modeMCP callCloses #1192
Test plan
python3 -m pytest hooks/lib/test_mode_engine.py— 22 tests passedpython3 -m pytest hooks/test_user_prompt_submit.py— 32 tests passedyarn workspace codingbuddy test— 5808 tests passedPLAN: testin Claude Code without MCP server running — should output mode instructions