Build macOS releases on a supported Apple silicon runner only - #56
Conversation
The x86_64 job targeted macos-13, which GitHub has retired, so it queued forever with no runner to pick it up and blocked publish behind it. The arm64 job used macos-14, which is now deprecated. Move arm64 to macos-15 and drop Intel entirely: Apple silicon covers every Mac sold since 2020, and Intel users can build from source. The matrix keeps its shape so Intel can be restored with a two-line entry. Follow through in the cask generator, which required both architectures and would have failed on an arm-only release.
📝 WalkthroughWalkthroughThe macOS release workflow now builds only Apple Silicon artifacts. Homebrew cask generation uses ARM64 metadata. The README directs Intel users to build from source. ChangesApple Silicon macOS distribution
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 87-89: Update the comment beside the macOS release matrix to
remove the inaccurate claim that Apple silicon covers every Mac sold since 2020.
Keep the arm64-only matrix unchanged and explain the intentional release policy:
Intel artifacts are omitted, while Intel users can build from source; retain the
note about re-adding the x86_64 runner if that policy changes.
In `@README.md`:
- Around line 74-75: Update the earlier macOS installation paragraph in
README.md to remove the stale claim that packages are unavailable; state that
Apple silicon macOS releases are available, while Intel Mac users must build
from source with make install. Keep the surrounding installation guidance
unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 73caadd2-ead6-4205-9789-3a6ca7f3321b
📒 Files selected for processing (3)
.github/workflows/release.ymlREADME.mdscripts/update-cask.sh
| # Intel is intentionally absent: Apple silicon covers every Mac sold | ||
| # since 2020, and Intel users can build from source. Re-add with | ||
| # "- arch: x86_64 / runner: macos-15-intel" if that changes. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Replace the incorrect hardware-history rationale.
Intel Macs remained in Apple’s lineup after 2020. Keep the arm64-only matrix, but describe the release policy instead of claiming that Apple silicon covers every Mac sold since 2020.
Suggested wording
- # Intel is intentionally absent: Apple silicon covers every Mac sold
- # since 2020, and Intel users can build from source. Re-add with
- # "- arch: x86_64 / runner: macos-15-intel" if that changes.
+ # Intel is intentionally absent from this release. Intel users can
+ # build from source. Add an Intel matrix entry when a supported
+ # runner is available.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # Intel is intentionally absent: Apple silicon covers every Mac sold | |
| # since 2020, and Intel users can build from source. Re-add with | |
| # "- arch: x86_64 / runner: macos-15-intel" if that changes. | |
| # Intel is intentionally absent from this release. Intel users can | |
| # build from source. Add an Intel matrix entry when a supported | |
| # runner is available. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/release.yml around lines 87 - 89, Update the comment
beside the macOS release matrix to remove the inaccurate claim that Apple
silicon covers every Mac sold since 2020. Keep the arm64-only matrix unchanged
and explain the intentional release policy: Intel artifacts are omitted, while
Intel users can build from source; retain the note about re-adding the x86_64
runner if that policy changes.
| publishes for Apple silicon. Intel Macs get no release asset; build from source | ||
| with `make install` instead. Because the app is ad-hoc signed rather than |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Remove the stale statement that macOS packages are unavailable.
The earlier installation paragraph still says that packaged macOS releases are not available. That conflicts with the arm64 archive published by the workflow and with this cask section. Update the earlier paragraph to state that Apple silicon macOS releases are available and Intel users must build from source.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~74-~74: Did you mean the proper noun “Apple Silicon”?
Context: ...ndle the release workflow publishes for Apple silicon. Intel Macs get no release asset; build...
(APPLE_PRODUCTS)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` around lines 74 - 75, Update the earlier macOS installation
paragraph in README.md to remove the stale claim that packages are unavailable;
state that Apple silicon macOS releases are available, while Intel Mac users
must build from source with make install. Keep the surrounding installation
guidance unchanged.
1 participant
The v0.1.2 release hung with
build-macos (x86_64, macos-13)queued for 16+ minutes and no runner to pick it up.macos-13has been retired from GitHub Actions, so that job could never start, andpublishsat blocked behind it.macos-14, which the arm64 job used, is now flagged deprecated too. The arm64 build itself passed on its first real run, exercisinguv sync --locked,make build, the run-from-/smoke test, theInfo.plistassociation check, andpackage-macos.sh.Moves arm64 to
macos-15and drops Intel: Apple silicon covers every Mac sold since 2020, and Intel users can stillmake installfrom source. The matrix keeps its shape, so restoring Intel is a two-line entry withmacos-15-intel(the current label;macos-26-intelalso exists).update-cask.shfollowed suit. It required checksums for both architectures and would have failed outright on an arm-only release; the generated cask now carries a singlesha256anddepends_on arch: :arm64.After merge the
v0.1.2tag needs moving again to re-trigger the release.Summary by CodeRabbit