Skip to content

Build macOS releases on a supported Apple silicon runner only #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshCLWren merged 1 commit into from
Aug 8, 2026
Merged

Build macOS releases on a supported Apple silicon runner only #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,11 @@ jobs:
fail-fast: false
matrix:
include:
# Intel is intentionally absent: Apple silicon covers every Mac sold
# since 2020, and Intel users can build from source. Re-add with
# "- arch: x86_64 / runner: macos-15-intel" if that changes.
Comment on lines +87 to +89

@coderabbitai coderabbitai Bot Aug 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Replace the incorrect hardware-history rationale.

Intel Macs remained in Apple’s lineup after 2020. Keep the arm64-only matrix, but describe the release policy instead of claiming that Apple silicon covers every Mac sold since 2020.

Suggested wording 
-          # Intel is intentionally absent: Apple silicon covers every Mac sold
-          # since 2020, and Intel users can build from source. Re-add with
-          # "- arch: x86_64 / runner: macos-15-intel" if that changes.
+          # Intel is intentionally absent from this release. Intel users can
+          # build from source. Add an Intel matrix entry when a supported
+          # runner is available.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Intel is intentionally absent: Apple silicon covers every Mac sold
# since 2020, and Intel users can build from source. Re-add with
# "- arch: x86_64 / runner: macos-15-intel" if that changes.
# Intel is intentionally absent from this release. Intel users can
# build from source. Add an Intel matrix entry when a supported
# runner is available.
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/release.yml around lines 87 - 89, Update the comment
beside the macOS release matrix to remove the inaccurate claim that Apple
silicon covers every Mac sold since 2020. Keep the arm64-only matrix unchanged
and explain the intentional release policy: Intel artifacts are omitted, while
Intel users can build from source; retain the note about re-adding the x86_64
runner if that policy changes.

- arch: arm64
runner: macos-14
- arch: x86_64
runner: macos-13
runner: macos-15
runs-on: ${{ matrix.runner }}
steps:
- name: Check out exact selected commit
Expand Down
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,15 @@ brew install --cask cdisplayagain
```

The cask installs the same notarization-free bundle the release workflow
publishes for arm64 and Intel. Because the app is ad-hoc signed rather than
publishes for Apple silicon. Intel Macs get no release asset; build from source
with `make install` instead. Because the app is ad-hoc signed rather than
Comment on lines +74 to +75

@coderabbitai coderabbitai Bot Aug 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Remove the stale statement that macOS packages are unavailable.

The earlier installation paragraph still says that packaged macOS releases are not available. That conflicts with the arm64 archive published by the workflow and with this cask section. Update the earlier paragraph to state that Apple silicon macOS releases are available and Intel users must build from source.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~74-~74: Did you mean the proper noun “Apple Silicon”?
Context: ...ndle the release workflow publishes for Apple silicon. Intel Macs get no release asset; build...

(APPLE_PRODUCTS)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` around lines 74 - 75, Update the earlier macOS installation
paragraph in README.md to remove the stale claim that packages are unavailable;
state that Apple silicon macOS releases are available, while Intel Mac users
must build from source with make install. Keep the surrounding installation
guidance unchanged.

notarized, and Homebrew quarantines every cask download, the cask clears the
quarantine flag on install. See the
[tap README](https://github.com/JoshCLWren/homebrew-tap) if you would rather
handle that yourself with `--no-quarantine`. Building from source avoids the
question entirely, since a locally built app is never quarantined.

#### macOS app bundle (Apple silicon or Intel)
#### macOS app bundle (build from source)

Build a real `cdisplayagain.app` from a clone and install it, so `.cbz`/`.cbr`
files open on double-click:
Expand Down
12 changes: 5 additions & 7 deletions scripts/update-cask.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,28 +42,26 @@ lookup() {
}

arm_sha=$(lookup arm64)
intel_sha=$(lookup x86_64)

mkdir -p -- "$(dirname -- "$output")"
cat > "$output" <<EOF
cask "cdisplayagain" do
arch arm: "arm64", intel: "x86_64"

version "${version}"
sha256 arm: "${arm_sha}",
intel: "${intel_sha}"
sha256 "${arm_sha}"

url "https://github.com/${repo}/releases/download/v#{version}/cdisplayagain-#{version}-macos-#{arch}.zip",
url "https://github.com/${repo}/releases/download/v#{version}/cdisplayagain-#{version}-macos-arm64.zip",
verified: "github.com/${repo}/"
name "cdisplayagain"
desc "Minimalist remake of the CDisplay sequential comic viewer"
homepage "https://github.com/${repo}"

# Only Apple silicon builds are published; Intel users build from source.
depends_on arch: :arm64
depends_on macos: ">= :big_sur"

# package-macos.sh zips a versioned parent directory holding the bundle
# alongside install.sh and the license, so the app is one level down.
app "cdisplayagain-#{version}-macos-#{arch}/cdisplayagain.app"
app "cdisplayagain-#{version}-macos-arm64/cdisplayagain.app"

# The app is ad-hoc signed rather than notarized, so Gatekeeper blocks the
# quarantined copy Homebrew downloads until the flag is cleared.
Expand Down
Loading