Display IdOffsetRange fields#193
Closed
jishnub wants to merge 1 commit into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 5 5
Lines 280 280
=======================================
Hits 278 278
Misses 2 2
Continue to review full report at Codecov.
|
Member
|
Not a fan, unfortunately. Let's do some variant of #179 (it doesn't have to be Pairs syntax, the key is directly specifying both the axes and the values). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While #179 is still undecided, this is a stop-gap (and hopefully less disputed) solution. In my experience displaying the axes of an
OffsetArrayis necessary more in debugging than anything else, and having the offsets printed makes life easier. This makes interpreting the axis span a little trickier, but it's possible to get used to this.After this PR:
It's always possible to convert these to
UnitRanges wherever necessary: