Skip to content

Fix show for OffsetRanges (redo #200)#203

Merged
jishnub merged 1 commit into
JuliaArrays:masterfrom
jishnub:fixshow_OffsetRange
Feb 17, 2021
Merged

Fix show for OffsetRanges (redo #200)#203
jishnub merged 1 commit into
JuliaArrays:masterfrom
jishnub:fixshow_OffsetRange

Conversation

@jishnub
Copy link
Copy Markdown
Member

@jishnub jishnub commented Feb 13, 2021

Unfortunately my attempt at not displaying the parent types while printing OffsetRanges in #200 was buggy, and was not caught because of insufficient tests. This PR reverts that, so now the parent types will be printed as it used to be before #200. There might be a better solution using no_offset_view, but it's better to be conservative.

After this:

julia> r = OffsetVector(Base.IdentityUnitRange(-3:4), 2)
Base.IdentityUnitRange(-3:4) with indices -1:6

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2021

Codecov Report

Merging #203 (f5e0946) into master (0a5dc88) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #203   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files           5        5           
  Lines         286      286           
=======================================
  Hits          281      281           
  Misses          5        5           
Impacted Files Coverage Δ
src/OffsetArrays.jl 97.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a5dc88...f5e0946. Read the comment docs.

@jishnub jishnub merged commit b190e15 into JuliaArrays:master Feb 17, 2021
@jishnub jishnub deleted the fixshow_OffsetRange branch August 18, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant