Fix show for OffsetRanges (redo #200)#203
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 5 5
Lines 286 286
=======================================
Hits 281 281
Misses 5 5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately my attempt at not displaying the parent types while printing OffsetRanges in #200 was buggy, and was not caught because of insufficient tests. This PR reverts that, so now the parent types will be printed as it used to be before #200. There might be a better solution using
no_offset_view, but it's better to be conservative.After this: