Skip to content

Fix show for OffsetRanges (redo #200) #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jishnub merged 1 commit into from
Feb 17, 2021
Merged

Fix show for OffsetRanges (redo #200) #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OffsetArrays.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ indexing is faster with ranges =#
@propagate_inbounds Base.getindex(r::UnitRange{<:Integer}, s::IIUR) = IdentityUnitRange(r[no_offset_view(s)])

function Base.show(io::IO, r::OffsetRange)
show(io, UnitRange(r.parent))
show(io, r.parent)
print(io, " with indices ", UnitRange(axes(r, 1)))
end
Base.show(io::IO, ::MIME"text/plain", r::OffsetRange) = show(io, r)
Expand Down
9 changes: 5 additions & 4 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,10 +1004,11 @@ end
@test String(take!(io)) == "3:5 with indices 0:2"

# issue #198
r = axes(OffsetVector(1:10, -5), 1)
a = OffsetVector(r, 5)
show(io, a)
@test String(take!(io)) == "$(UnitRange(r)) with indices $(UnitRange(axes(a,1)))"
for r in [axes(OffsetVector(1:10, -5), 1), 1:1:2, 1.0:1.0:2.0, 1:-1:-5]
a = OffsetVector(r, 5)
show(io, a)
@test String(take!(io)) == "$r with indices $(UnitRange(axes(a,1)))"
end

d = Diagonal([1,2,3])
Base.print_array(io, d)
Expand Down