Fix sytrs! test: verify non-pivoting path directly instead of skipping#3039
Merged
Fix sytrs! test: verify non-pivoting path directly instead of skipping#3039
Conversation
The non-pivoting cusolver path was compared against LAPACK which always uses pivoting, making the comparison invalid. For the non-pivoting case, verify correctness directly by checking A * x ≈ b against the original inputs. Keep the LAPACK comparison for the pivoting case where both use the same algorithm. Also move the version check before matrix allocation to avoid unnecessary work when skipping. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3039 +/- ##
==========================================
- Coverage 89.49% 89.33% -0.17%
==========================================
Files 148 148
Lines 13047 13047
==========================================
- Hits 11676 11655 -21
- Misses 1371 1392 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-pivoting cusolver path was compared against LAPACK which always uses pivoting, making the comparison invalid. For the non-pivoting case, verify correctness directly by checking A * x ≈ b against the original inputs. Keep the LAPACK comparison for the pivoting case where both use the same algorithm.
As observed on #3020