Skip to content

Fix sytrs! test: verify non-pivoting path directly instead of skipping #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maleadt merged 1 commit into from
Mar 3, 2026
Merged

Fix sytrs! test: verify non-pivoting path directly instead of skipping #3039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions test/libraries/cusolver/dense_generic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,29 +124,34 @@ p = 5
@testset "sytrs!" begin
@testset "uplo = $uplo" for uplo in ('L', 'U')
@testset "pivoting = $pivoting" for pivoting in (false, true)
!pivoting && (CUSOLVER.version() < v"11.7.2") && continue
A = rand(elty,n,n)
B = rand(elty,n,p)
C = rand(elty,n)
A = A + transpose(A)
d_A = CuMatrix(A)
d_B = CuMatrix(B)
d_C = CuVector(C)
!pivoting && (CUSOLVER.version() < v"11.7.2") && continue
if pivoting
d_A, d_ipiv, _ = CUSOLVER.sytrf!(uplo, d_A; pivoting)
d_ipiv = CuVector{Int64}(d_ipiv)
CUSOLVER.sytrs!(uplo, d_A, d_ipiv, d_B)
CUSOLVER.sytrs!(uplo, d_A, d_ipiv, d_C)
A, ipiv, _ = LAPACK.sytrf!(uplo, A)
LAPACK.sytrs!(uplo, A, ipiv, B)
LAPACK.sytrs!(uplo, A, ipiv, C)
@test B ≈ collect(d_B)
@test C ≈ collect(d_C)
else
d_A, _ = CUSOLVER.sytrf!(uplo, d_A; pivoting)
CUSOLVER.sytrs!(uplo, d_A, d_B)
CUSOLVER.sytrs!(uplo, d_A, d_C)
# Verify correctness directly: non-pivoting cusolver cannot be
# compared against LAPACK (which always pivots), so instead check
# that A * x ≈ b for the original inputs.
@test A * collect(d_B) ≈ B
@test A * collect(d_C) ≈ C
end
A, ipiv, _ = LAPACK.sytrf!(uplo, A)
LAPACK.sytrs!(uplo, A, ipiv, B)
LAPACK.sytrs!(uplo, A, ipiv, C)
@test B ≈ collect(d_B)
@test C ≈ collect(d_C)
end
end
end
Expand Down