ci: Test both Windows debug and release builds#45
Merged
Conversation
aqnuep
force-pushed
the
aqnuep/ci-win-rel
branch
2 times, most recently
from
c6a701d to
d1f9d81
Compare
There are wider issues with the entire handling of
location and component assignment in VVL, but this
change does not attempt to fix them.
This issue was discovered "thanks to" an MSVC compiler
bug that incorrectly optimized a piece of this code such
that a division by zero exception was caused in this
piece of code:
if (vector_components != 0 && j != 0
&& j % vector_components == 0) {
While that is a clear compiler bug, it did reveal a few
other bugs in the code around this conditional.
aqnuep
force-pushed
the
aqnuep/ci-win-rel
branch
from
d1f9d81 to
2696f71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.