Skip to content

Maintenance pre-commit and picture#108

Merged
finetjul merged 13 commits into
Kitware:masterfrom
UlysseDurand:maintenance
Jun 2, 2026
Merged

Maintenance pre-commit and picture#108
finetjul merged 13 commits into
Kitware:masterfrom
UlysseDurand:maintenance

Conversation

@UlysseDurand

@UlysseDurand UlysseDurand commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

As requested in Kitware/trame#842

  • pre-commit:
    Added same pre-commit rules as in the cookiecutter

  • picture:
    Added picture from the documentation

In Kitware/trame#842 the Web versioning isn't checked when it was added in
c9463ef

jourdain
jourdain reviewed Apr 13, 2026
View reviewed changes
Comment thread .pre-commit-config.yaml Outdated
jourdain
jourdain reviewed Apr 13, 2026
View reviewed changes
Comment thread .pre-commit-config.yaml
@bourdaisj

bourdaisj commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

@jourdain Based on what you said in your comments, should we also update the cookiecutter? see cookiecutter pre-commit

@jourdain

jourdain commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

yes we should

@UlysseDurand

UlysseDurand commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

My mistake last time I didn't update the pyproject.toml which drives the pre-commit checks. I spent some time doing it and changing all the files for them to match the ruff formatting: 146b233.

jourdain
jourdain reviewed Apr 20, 2026
View reviewed changes
Comment thread CHANGELOG.md
jourdain
jourdain reviewed Apr 20, 2026
View reviewed changes
Comment thread .flake8 Outdated
jourdain
jourdain reviewed Apr 20, 2026
View reviewed changes
Comment thread , Outdated
jourdain
jourdain reviewed Apr 20, 2026
View reviewed changes
Comment thread tests/test_import.py Outdated
jourdain
jourdain reviewed Apr 20, 2026
View reviewed changes
Comment thread tests/requirements.txt Outdated
jourdain
jourdain reviewed Apr 20, 2026
View reviewed changes
Comment thread src/trame_vtk/tools/static_viewer.html
jourdain
jourdain reviewed Apr 20, 2026
View reviewed changes
Comment thread src/trame_vtk/modules/vtk/serializers/mesh.py Outdated
jourdain
jourdain reviewed Apr 20, 2026
View reviewed changes
Comment thread src/trame_vtk/modules/vtk/serializers/mesh.py Outdated
jourdain
jourdain reviewed Apr 20, 2026
View reviewed changes
Comment thread src/trame_vtk/modules/vtk/protocols/mouse_handler.py
UlysseDurand added a commit to UlysseDurand/trame-vtk that referenced this pull request Apr 20, 2026
@UlysseDurand
ci(pre-commit): revert CHANGELOG.md and make prettier ignore it
86f4a5d 
Ref: Kitware#108 (comment)
UlysseDurand added a commit to UlysseDurand/trame-vtk that referenced this pull request Apr 20, 2026
@UlysseDurand
ci(pre-commit): correct pre-commit changes
42d2a9a 
- Remove .flake8 file
- Right noqa codes for test_import.py
- Revert and ignore static_viewer.html from prettier

Ref: Kitware#108 (comment)
Ref: Kitware#108 (comment)
Ref: Kitware#108 (comment)
UlysseDurand added a commit to UlysseDurand/trame-vtk that referenced this pull request Apr 20, 2026
@UlysseDurand
ci(pre-commit): put right import order back
f33c5fd 
Ref: Kitware#108 (comment)
jourdain
jourdain reviewed Apr 23, 2026
View reviewed changes
Comment thread src/trame_vtk/modules/vtk/protocols/view_port.py Outdated
jourdain
jourdain reviewed Apr 23, 2026
View reviewed changes
Comment thread src/trame_vtk/modules/vtk/protocols/view_port.py Outdated

@export_rpc("viewport.axes.center.visibility.update")
def update_center_axes_visibility(self, view_id, show_axis):
def update_center_axes_visibility(self, view_id, _depth):

@jourdain jourdain Apr 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why about that change of name?

@UlysseDurand UlysseDurand Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, it comes from a bad "find and replace" I did.
This UlysseDurand@77fa173 puts _show_axis.

jourdain
jourdain reviewed Apr 23, 2026
View reviewed changes
Comment thread src/trame_vtk/modules/vtk/serializers/data.py Outdated
jourdain
jourdain reviewed Apr 23, 2026
View reviewed changes
Comment thread src/trame_vtk/modules/vtk/serializers/initialize.py
CONVERT_LUT = False
SKIP_LIGHT = False

class LUTConfig:

@jourdain jourdain Apr 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is that coming from?

@UlysseDurand UlysseDurand Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had these pre-commit errors that indicate that no global should be used

https://docs.astral.sh/ruff/rules/global-statement^[\PLW0603^[\ Using the global statement to update `CONVERT_LUT` is discouraged
  --> src/trame_vtk/modules/vtk/serializers/initialize.py:40:12
   |
39 | def encode_lut(value=True):
40 |     global CONVERT_LUT
   |            ^^^^^^^^^^^
 |     CONVERT_LUT = value
   |

https://docs.astral.sh/ruff/rules/global-statement^[\PLW0603^[\ Using the global statement to update `SKIP_LIGHT` is discouraged
  --> src/trame_vtk/modules/vtk/serializers/initialize.py:45:12
   |
44 | def skip_light(value=True):
45 |     global SKIP_LIGHT
   |            ^^^^^^^^^^
46 |     SKIP_LIGHT = value
   |

https://docs.astral.sh/ruff/rules/global-variable-not-assigned^[\PLW0602^[\ Using global for `CONVERT_LUT` but no assignment is done
  --> src/trame_vtk/modules/vtk/serializers/initialize.py:50:12
   |
49 | def lookup_table_serializer_selector(*args, **kwargs):
50 |     global CONVERT_LUT
   |            ^^^^^^^^^^^
 |     if CONVERT_LUT:
52 |         return lookup_table_serializer2(*args, **kwargs)

jourdain
jourdain reviewed Apr 23, 2026
View reviewed changes
Comment thread src/trame_vtk/modules/vtk/serializers/mesh.py Outdated
jourdain
jourdain reviewed Apr 23, 2026
View reviewed changes
Comment thread src/trame_vtk/modules/vtk/serializers/mesh.py
jourdain
jourdain reviewed Apr 23, 2026
View reviewed changes
Comment thread src/trame_vtk/modules/vtk/widget.py Outdated
UlysseDurand added a commit to UlysseDurand/trame-vtk that referenced this pull request Apr 27, 2026
@UlysseDurand
ci(pre-commit): revert the mistake of changing show_axis to _depth
77fa173 
Now it is replaced with `_show_axis`

Ref: Kitware#108 (comment)
Ref: Kitware#108 (comment)
UlysseDurand added a commit to UlysseDurand/trame-vtk that referenced this pull request Apr 27, 2026
@UlysseDurand
ci(pre-commit): Change variable name, handle None, change import order
b6ebad5 
- Revert variable name for kwarg usage (add noqa ARG001) in imagedata
  serializer
- Handle None data array in mesh serialization
- Change import order

Ref: Kitware#108 (comment)
Ref: Kitware#108 (comment)
Ref: Kitware#108 (comment)
Ref: Kitware#108 (comment)
@jourdain

jourdain commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

LGTM, but you need to resolve conflicts.

UlysseDurand added 11 commits June 1, 2026 15:00
@UlysseDurand
ci(pre-commit): copy from cookiecutter
365b97a
@UlysseDurand
ci(pre-commit): change pre-commit as in trame-cookiecutter
f5a40a6
@UlysseDurand
ci(pre-commit): correct most of the pre-commit errors
0d7fb06
@UlysseDurand
ci(pre-commit): revert CHANGELOG.md and make prettier ignore it
75d1536 
Ref: Kitware#108 (comment)
@UlysseDurand
ci(pre-commit): correct pre-commit changes
10fa7d6 
- Remove .flake8 file
- Right noqa codes for test_import.py
- Revert and ignore static_viewer.html from prettier

Ref: Kitware#108 (comment)
Ref: Kitware#108 (comment)
Ref: Kitware#108 (comment)
@UlysseDurand
ci(pre-commit): put right import order back
7e5a64e 
Ref: Kitware#108 (comment)
@UlysseDurand
ci(pre-commit): bump vtk and pyvista for tests
837df4c 
Ref: https://github.com/Kitware/trame-vtk/pull/108/changes/
BASE..146b233#r3108179503
@UlysseDurand
ci(pre-commit): make volume render test work with newer pyvista and vtk
54ed5bf 
Ref: Kitware@76b00f2
Ref: https://github.com/Kitware/trame-vtk/actions/runs/24671570184/job/72314591774?pr=108
@UlysseDurand
ci(pre-commit): revert the mistake of changing show_axis to _depth
1e23908 
Now it is replaced with `_show_axis`

Ref: Kitware#108 (comment)
Ref: Kitware#108 (comment)
@UlysseDurand
ci(pre-commit): Change variable name, handle None, change import order
caf4a7c 
- Revert variable name for kwarg usage (add noqa ARG001) in imagedata
  serializer
- Handle None data array in mesh serialization
- Change import order

Ref: Kitware#108 (comment)
Ref: Kitware#108 (comment)
Ref: Kitware#108 (comment)
Ref: Kitware#108 (comment)
@UlysseDurand
ci(pre-commit): change _ to _kwargs when replaced by error
f692eb0
@UlysseDurand

UlysseDurand commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Sorry I pushed without checking if tests pass locally (they don't), I will put a comment when the PR is ready for review again

@UlysseDurand

UlysseDurand commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Tests seem to pass locally (not thanks to my last commit, I made a mistake running them before), it is ready for review

@finetjul finetjul merged commit 4104219 into Kitware:master Jun 2, 2026
3 checks passed
@UlysseDurand UlysseDurand mentioned this pull request Jun 3, 2026
Merged
@Jo-Byr Jo-Byr mentioned this pull request Jun 3, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jourdain jourdain jourdain approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@UlysseDurand @bourdaisj @jourdain @finetjul