Skip to content

Update cache dependency paths in CI workflow#212

Open
mubking wants to merge 1 commit intoLabsCrypt:mainfrom
mubking:patch-1
Open

Update cache dependency paths in CI workflow#212
mubking wants to merge 1 commit intoLabsCrypt:mainfrom
mubking:patch-1

Conversation

@mubking
Copy link
Copy Markdown
Contributor

@mubking mubking commented Feb 26, 2026

Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test addition or update

Related Issues

Closes #

Changes Made

Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Steps

Breaking Changes

Breaking Changes:

Migration Guide:

Screenshots/Demo

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have checked for breaking changes and documented them if applicable

Additional Notes

Copy link
Copy Markdown
Contributor

@ogazboiz ogazboiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mubking, thanks for trying to fix the CI cache issue!

heads up though — changing cache-dependency-path from package-lock.json to package.json is actually the wrong fix here. the cache: 'npm' option in actions/setup-node is specifically designed to look at the lock file to determine when the cache should be invalidated. pointing it at package.json means the cache won't bust when your actual dependency tree changes, which can cause stale cache issues.

the correct fix is to make sure the lock files exist at the right paths:

  • frontend/package-lock.json
  • backend/package-lock.json

if those files are missing, run npm install in each folder to generate them and commit them. then revert the cache-dependency-path lines back to pointing at the lock files.

also — i noticed you have four open PRs (#212, #213, #214, #215) that all attempt the same CI fix. please close the older ones and just keep the latest single PR once you have the correct fix. having multiple open PRs for the same thing makes it hard to track.

this PR also has merge conflicts — once you've made the fix above, rebase on main to clear those.

happy to help if you're stuck — jump in on Telegram: https://t.me/+DOylgFv1jyJlNzM0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants